Skip to content

Add comments and ut. - #62

Merged
JasmineJ1230 merged 1 commit into
capa-cloud:feature/metricsfrom
JasmineJ1230:feature/metrics
Dec 1, 2021
Merged

Add comments and ut.#62
JasmineJ1230 merged 1 commit into
capa-cloud:feature/metricsfrom
JasmineJ1230:feature/metrics

Conversation

@JasmineJ1230

Copy link
Copy Markdown
Contributor

Description

Add comments and ut.
Add CapaMeterSpi.

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • Code compiles correctly
  • Created/updated tests
  • Extended the documentation

Add CapaMeterSpi.
@codecov-commenter

Copy link
Copy Markdown

Codecov Report

Merging #62 (c9736fa) into feature/metrics (baa605b) will increase coverage by 4.11%.
The diff coverage is n/a.

Impacted file tree graph

@@                  Coverage Diff                  @@
##             feature/metrics      #62      +/-   ##
=====================================================
+ Coverage              58.20%   62.32%   +4.11%     
- Complexity               441      455      +14     
=====================================================
  Files                     99       99              
  Lines                   1816     1672     -144     
  Branches                 175      140      -35     
=====================================================
- Hits                    1057     1042      -15     
+ Misses                   668      540     -128     
+ Partials                  91       90       -1     
Impacted Files Coverage Δ
...up/rxcloud/capa/infrastructure/CapaProperties.java 50.00% <0.00%> (-9.68%) ⬇️
...up/rxcloud/capa/spi/http/CapaSerializeHttpSpi.java 62.88% <0.00%> (-4.69%) ⬇️
...up/rxcloud/capa/infrastructure/utils/SpiUtils.java 88.88% <0.00%> (-1.92%) ⬇️
...va/group/rxcloud/capa/component/http/CapaHttp.java 100.00% <0.00%> (ø)
...ud/capa/component/CapaConfigurationProperties.java
...group/rxcloud/capa/spi/telemetry/CapaMeterSpi.java 0.00% <0.00%> (ø)
...pa/infrastructure/serializer/ObjectSerializer.java 19.64% <0.00%> (+1.16%) ⬆️
...component/telemetry/metrics/CapaMeterProvider.java 100.00% <0.00%> (+40.00%) ⬆️
.../component/telemetry/metrics/CapaMeterWrapper.java 50.00% <0.00%> (+50.00%) ⬆️
...mponent/telemetry/metrics/CapaMetricsExporter.java 100.00% <0.00%> (+75.00%) ⬆️
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update baa605b...c9736fa. Read the comment docs.

@JasmineJ1230
JasmineJ1230 merged commit da9bf31 into capa-cloud:feature/metrics Dec 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants