Skip to content

Separate the context related features from trace. - #51

Merged
kevinten10 merged 1 commit into
capa-cloud:feature/metricsfrom
JasmineJ1230:feature/metrics_optimize
Nov 27, 2021
Merged

Separate the context related features from trace.#51
kevinten10 merged 1 commit into
capa-cloud:feature/metricsfrom
JasmineJ1230:feature/metrics_optimize

Conversation

@JasmineJ1230

@JasmineJ1230 JasmineJ1230 commented Nov 26, 2021

Copy link
Copy Markdown
Contributor

Description

Separate the context related features from trace.
Add unit tests and comments.

Issue reference

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • Code compiles correctly
  • Created/updated tests
  • Extended the documentation

@codecov-commenter

Copy link
Copy Markdown

Codecov Report

Merging #51 (3a7499b) into feature/metrics (c0788cb) will increase coverage by 35.46%.
The diff coverage is n/a.

Impacted file tree graph

@@                  Coverage Diff                   @@
##             feature/metrics      #51       +/-   ##
======================================================
+ Coverage              30.96%   66.42%   +35.46%     
- Complexity               179      432      +253     
======================================================
  Files                     82       82               
  Lines                   1531     1498       -33     
  Branches                 144      126       -18     
======================================================
+ Hits                     474      995      +521     
+ Misses                  1008      417      -591     
- Partials                  49       86       +37     
Impacted Files Coverage Δ
...roup/rxcloud/capa/spi/telemetry/CapaTracerSpi.java 0.00% <0.00%> (ø)
...rxcloud/capa/spi/telemetry/CapaSpanBuilderSpi.java 0.00% <0.00%> (ø)
...cloud/capa/spi/telemetry/CapaReadWriteSpanSpi.java 0.00% <0.00%> (ø)
...cloud/capa/spi/telemetry/CapaTracerBuilderSpi.java 0.00% <0.00%> (ø)
...capa/spi/telemetry/CapaContextAsyncWrapperSpi.java 0.00% <0.00%> (ø)
...ud/capa/component/telemetry/trace/CapaSampler.java
...onent/telemetry/trace/config/SpanLimitsConfig.java
...oup/rxcloud/capa/component/telemetry/SpiUtils.java
...component/telemetry/trace/config/TracerConfig.java
...component/telemetry/trace/CapaSamplerProvider.java
... and 36 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c0788cb...3a7499b. Read the comment docs.

@kevinten10

Copy link
Copy Markdown
Member

LGTM.

@kevinten10
kevinten10 merged commit 19b2973 into capa-cloud:feature/metrics Nov 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants