Skip to content

Feat add log api #45

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kevinten10 merged 3 commits into from
Nov 22, 2021
Merged

Feat add log api #45

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
491ec30
style(update a new feature): update the abstract log api in compoent
dgz-pg Nov 22, 2021
92c4aab
Merge branch 'feature/metrics' into feat-addLogApi
dgz-pg Nov 22, 2021
4bb42df
style(update a new feature): update the abstract log api in compoent
dgz-pg Nov 22, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 11 additions & 6 deletions ...rc/main/java/group/rxcloud/capa/component/telemetry/log/agent/CapaLog4jAppenderAgent.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,12 +16,6 @@
*/
package group.rxcloud.capa.component.telemetry.log.agent;

/**
* @Author gpeng
* @Date 2021/11/17 14:16
*/

import group.rxcloud.capa.component.telemetry.log.appender.CapaLog4jAppender;
import group.rxcloud.capa.infrastructure.config.CapaProperties;
import org.apache.logging.log4j.core.Appender;
import org.apache.logging.log4j.core.Filter;
Expand Down Expand Up @@ -116,5 +110,16 @@ public void append(LogEvent event) {
logAppender.appendLog(event);
}

/**
* The abstract api of the log4j appender impl.Implement this and provide your specific impl.
*/
public interface CapaLog4jAppender {

/**
* Deal with the log.
*
* @param event The log event.
*/
void appendLog(LogEvent event);
}
}
14 changes: 13 additions & 1 deletion .../main/java/group/rxcloud/capa/component/telemetry/log/agent/CapaLogbackAppenderAgent.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@
package group.rxcloud.capa.component.telemetry.log.agent;

import ch.qos.logback.core.UnsynchronizedAppenderBase;
import group.rxcloud.capa.component.telemetry.log.appender.CapaLogbackAppender;
import group.rxcloud.capa.infrastructure.config.CapaProperties;

import java.lang.reflect.Constructor;
Expand Down Expand Up @@ -73,4 +72,17 @@ public static CapaLogbackAppender buildCapaLogbackAppender() {
protected void append(EVENT event) {
logbackAppender.appendLog(event);
}

/**
* The abstract api of the logback appender impl.Implement this and provide your specific impl.
*/
public interface CapaLogbackAppender<EVENT> {

/**
* Deal with the log.
*
* @param event The log event.
*/
void appendLog(EVENT event);
}
}
32 changes: 0 additions & 32 deletions .../src/main/java/group/rxcloud/capa/component/telemetry/log/appender/CapaLog4jAppender.java
View file
Open in desktop

This file was deleted.

31 changes: 0 additions & 31 deletions ...rc/main/java/group/rxcloud/capa/component/telemetry/log/appender/CapaLogbackAppender.java
View file
Open in desktop

This file was deleted.

5 changes: 2 additions & 3 deletions sdk-spi-demo/src/main/java/group/rxcloud/capa/spi/demo/telemetry/log/DemoLog4jAppender.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,11 +16,10 @@
*/
package group.rxcloud.capa.spi.demo.telemetry.log;

import group.rxcloud.capa.component.telemetry.log.appender.CapaLog4jAppender;
import group.rxcloud.capa.component.telemetry.log.agent.CapaLog4jAppenderAgent;
import org.apache.logging.log4j.core.LogEvent;


public class DemoLog4jAppender extends CapaLog4jAppender {
public class DemoLog4jAppender implements CapaLog4jAppenderAgent.CapaLog4jAppender {

@Override
public void appendLog(LogEvent event) {
Expand Down
4 changes: 2 additions & 2 deletions ...spi-demo/src/main/java/group/rxcloud/capa/spi/demo/telemetry/log/DemoLogbackAppender.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,9 +17,9 @@
package group.rxcloud.capa.spi.demo.telemetry.log;

import ch.qos.logback.classic.spi.ILoggingEvent;
import group.rxcloud.capa.component.telemetry.log.appender.CapaLogbackAppender;
import group.rxcloud.capa.component.telemetry.log.agent.CapaLogbackAppenderAgent;

public class DemoLogbackAppender extends CapaLogbackAppender<ILoggingEvent> {
public class DemoLogbackAppender implements CapaLogbackAppenderAgent.CapaLogbackAppender<ILoggingEvent> {

public DemoLogbackAppender() {
}
Expand Down
4 changes: 2 additions & 2 deletions sdk-spi-demo/src/main/resources/capa-component-log.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
group.rxcloud.capa.component.telemetry.log.appender.CapaLog4jAppender=group.rxcloud.capa.spi.demo.telemetry.log.DemoLog4jAppender
group.rxcloud.capa.component.telemetry.log.appender.CapaLogbackAppender=group.rxcloud.capa.spi.demo.telemetry.log.DemoLogbackAppender
group.rxcloud.capa.component.telemetry.log.agent.CapaLog4jAppenderAgent$CapaLog4jAppender=group.rxcloud.capa.spi.demo.telemetry.log.DemoLog4jAppender
group.rxcloud.capa.component.telemetry.log.agent.CapaLogbackAppenderAgent$CapaLogbackAppender=group.rxcloud.capa.spi.demo.telemetry.log.DemoLogbackAppender