Skip to content

style update log api #43

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kevinten10 merged 4 commits into from
Nov 18, 2021
Merged

style update log api #43

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
732d0e1
feat(Add a new feature): update the abstract log api in compoent
dgz-pg Nov 18, 2021
da37ae3
style(update a new feature): update the abstract log api in compoent
dgz-pg Nov 18, 2021
968d71a
update demo
dgz-pg Nov 18, 2021
232c405
make dependency optional
dgz-pg Nov 18, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions sdk-component/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,12 +76,14 @@
<dependency>
<groupId>org.apache.logging.log4j</groupId>
<artifactId>log4j-core</artifactId>
<optional>true</optional>
<version>${log4j.version}</version>
</dependency>
<!-- logback -->
<dependency>
<groupId>ch.qos.logback</groupId>
<artifactId>logback-core</artifactId>
<optional>true</optional>
<version>${logback.version}</version>
</dependency>
<dependency>
Expand Down
2 changes: 1 addition & 1 deletion ...rc/main/java/group/rxcloud/capa/component/telemetry/log/agent/CapaLog4jAppenderAgent.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
* @Date 2021/11/17 14:16
*/

import group.rxcloud.capa.component.telemetry.log.CapaLog4jAppender;
import group.rxcloud.capa.component.telemetry.log.appender.CapaLog4jAppender;
import group.rxcloud.capa.infrastructure.config.CapaProperties;
import org.apache.logging.log4j.core.Appender;
import org.apache.logging.log4j.core.Filter;
Expand Down
2 changes: 1 addition & 1 deletion .../main/java/group/rxcloud/capa/component/telemetry/log/agent/CapaLogbackAppenderAgent.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
package group.rxcloud.capa.component.telemetry.log.agent;

import ch.qos.logback.core.UnsynchronizedAppenderBase;
import group.rxcloud.capa.component.telemetry.log.CapaLogbackAppender;
import group.rxcloud.capa.component.telemetry.log.appender.CapaLogbackAppender;
import group.rxcloud.capa.infrastructure.config.CapaProperties;

import java.lang.reflect.Constructor;
Expand Down
9 changes: 4 additions & 5 deletions ...nent/telemetry/log/CapaLog4jAppender.java → ...metry/log/appender/CapaLog4jAppender.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,20 +14,19 @@
* See the License for the specific language governing permissions and
* limitations under the License.
*/
package group.rxcloud.capa.component.telemetry.log;

package group.rxcloud.capa.component.telemetry.log.appender;

import org.apache.logging.log4j.core.LogEvent;

/**
* The interface of the log4j appender impl.Implement this and provide your specific impl.
* The abstract api of the log4j appender impl.Implement this and provide your specific impl.
*/
public interface CapaLog4jAppender {
public abstract class CapaLog4jAppender {

/**
* Deal with the log.
*
* @param event The log event.
*/
void appendLog(LogEvent event);
public abstract void appendLog(LogEvent event);
}
8 changes: 4 additions & 4 deletions ...nt/telemetry/log/CapaLogbackAppender.java → ...try/log/appender/CapaLogbackAppender.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,18 +14,18 @@
* See the License for the specific language governing permissions and
* limitations under the License.
*/
package group.rxcloud.capa.component.telemetry.log;
package group.rxcloud.capa.component.telemetry.log.appender;


/**
* The interface of the logback appender impl.Implement this and provide your specific impl.
* The abstract api of the logback appender impl.Implement this and provide your specific impl.
*/
public interface CapaLogbackAppender<EVENT> {
public abstract class CapaLogbackAppender<EVENT> {

/**
* Deal with the log.
*
* @param event The log event.
*/
void appendLog(EVENT event);
public abstract void appendLog(EVENT event);
}
6 changes: 3 additions & 3 deletions .../capa/spi/demo/log/DemoLog4jAppender.java → ...demo/telemetry/log/DemoLog4jAppender.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,13 +14,13 @@
* See the License for the specific language governing permissions and
* limitations under the License.
*/
package group.rxcloud.capa.spi.demo.log;
package group.rxcloud.capa.spi.demo.telemetry.log;

import group.rxcloud.capa.component.telemetry.log.CapaLog4jAppender;
import group.rxcloud.capa.component.telemetry.log.appender.CapaLog4jAppender;
import org.apache.logging.log4j.core.LogEvent;


public class DemoLog4jAppender implements CapaLog4jAppender {
public class DemoLog4jAppender extends CapaLog4jAppender {

@Override
public void appendLog(LogEvent event) {
Expand Down
6 changes: 3 additions & 3 deletions ...apa/spi/demo/log/DemoLogbackAppender.java → ...mo/telemetry/log/DemoLogbackAppender.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,12 +14,12 @@
* See the License for the specific language governing permissions and
* limitations under the License.
*/
package group.rxcloud.capa.spi.demo.log;
package group.rxcloud.capa.spi.demo.telemetry.log;

import ch.qos.logback.classic.spi.ILoggingEvent;
import group.rxcloud.capa.component.telemetry.log.CapaLogbackAppender;
import group.rxcloud.capa.component.telemetry.log.appender.CapaLogbackAppender;

public class DemoLogbackAppender implements CapaLogbackAppender<ILoggingEvent> {
public class DemoLogbackAppender extends CapaLogbackAppender<ILoggingEvent> {

public DemoLogbackAppender() {
}
Expand Down
4 changes: 2 additions & 2 deletions sdk-spi-demo/src/main/resources/capa-component-log.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
group.rxcloud.capa.component.telemetry.log.CapaLog4jAppender=group.rxcloud.capa.spi.demo.log.DemoLog4jAppender
group.rxcloud.capa.component.telemetry.log.CapaLogbackAppender=group.rxcloud.capa.spi.demo.log.DemoLogbackAppender
group.rxcloud.capa.component.telemetry.log.appender.CapaLog4jAppender=group.rxcloud.capa.spi.demo.telemetry.log.DemoLog4jAppender
group.rxcloud.capa.component.telemetry.log.appender.CapaLogbackAppender=group.rxcloud.capa.spi.demo.telemetry.log.DemoLogbackAppender