Backport changes to a new 1.x release branch. - #301
Merged
Merged
Conversation
Windows' `NtCreateFile` has an ability to take a directory and a relative path, so use that to implement `open_unchecked` instead of using path concatenation. We still use concatenation for other functions, but this is the first step to rewriting those to avoid it. Fixes #226.
Always use `open_unchecked` with no access for implementing `stat` on Windows, as that now uses the new `NtCreateFile` path.
Use `let _ = ambient_authority;` to suppress unused argument warnings rather than naming arguments `_`, because argument names show up in the documentation, and the fact that these arguments are unused is not part of the public interface.
* Add a `Pool::insert_ip_net_any_port` function. Add a function to `Pool` to allow inserting a network that can accept any port. * Add support for port ranges, and add some unit tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This backports everything except #297 which is the update to rustix 0.37 to a new 1.x release branch. I don't think rustix is a public dependency of cap-std, but at this moment I'm not sufficiently sure about that, so to be safe for now, I'm omitting that so that it doesn't block other patches.