Skip to content

fix(action): enforce compatibility window#20505

Merged
RainbowDashy merged 1 commit into
mainfrom
p0ny/bytebase-action-compat-window
Jun 4, 2026
Merged

fix(action): enforce compatibility window#20505
RainbowDashy merged 1 commit into
mainfrom
p0ny/bytebase-action-compat-window

Conversation

@RainbowDashy

Copy link
Copy Markdown
Contributor

Summary

  • Enforce bytebase-action compatibility checks as command errors when outside the supported window.
  • Support dated Cloud versions in the form cloud-YYYYMMDD and keep Cloud recommendations on the cloud action tag.
  • Add action command tests for release, Cloud, parse, and outside-window compatibility cases.

Breaking Changes

  • bytebase-action check and bytebase-action rollout now exit with an error when the CLI/action version is outside the compatibility window instead of only logging a warning.

Compatibility Impact

  • Cloud compatibility requires dated Cloud versions (cloud-YYYYMMDD) within 7 days.
  • Self-hosted compatibility requires the same major version and a 2-minor-version window.
  • Within-window version mismatches still warn and continue; exact matches log success.

Test Plan

  • go test -v -count=1 ./action/command
  • golangci-lint run --allow-parallel-runners
  • golangci-lint run --fix --allow-parallel-runners
  • go build -ldflags "-w -s" -p=16 -o ./bytebase-build/bytebase ./backend/bin/server/main.go

Pre-PR Checklist

  • Breaking behavior documented and labeled.
  • Composite-PK query safety skipped; no backend store or migrator changes.
  • SonarCloud config checked; new action/**/*_test.go file is already covered by test and CPD patterns.

@RainbowDashy RainbowDashy requested a review from a team as a code owner June 4, 2026 07:40
@cla-bot cla-bot Bot added the cla-signed label Jun 4, 2026

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 198c2f194e

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread action/command/root.go Outdated
@RainbowDashy RainbowDashy force-pushed the p0ny/bytebase-action-compat-window branch from 198c2f1 to c311b41 Compare June 4, 2026 07:48

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: c311b41d75

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread action/command/root.go Outdated
@RainbowDashy RainbowDashy force-pushed the p0ny/bytebase-action-compat-window branch from c311b41 to e7234a0 Compare June 4, 2026 08:00
@sonarqubecloud

sonarqubecloud Bot commented Jun 4, 2026

Copy link
Copy Markdown

@RainbowDashy RainbowDashy enabled auto-merge (squash) June 4, 2026 08:07
@RainbowDashy RainbowDashy merged commit 770d941 into main Jun 4, 2026
16 checks passed
@RainbowDashy RainbowDashy deleted the p0ny/bytebase-action-compat-window branch June 4, 2026 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants