Skip to content

fix: parse Oracle omni scripts via splitter#20432

Merged
rebelice merged 1 commit into
mainfrom
codex/fix-oracle-omni-wrapper
May 28, 2026
Merged

fix: parse Oracle omni scripts via splitter#20432
rebelice merged 1 commit into
mainfrom
codex/fix-oracle-omni-wrapper

Conversation

@rebelice

Copy link
Copy Markdown
Contributor

Summary

  • Route Bytebase Oracle ParsePLSQLOmni through omni's script-level parser so SQL*Plus slash delimiters are split before parsing.
  • Preserve the existing *ast.List / *ast.RawStmt wrapper shape for current callers.
  • Add coverage for slash-terminated PL/SQL scripts.

Test Plan

  • go test ./backend/plugin/parser/plsql -run '^TestParsePLSQLOmni' -count=1\n- golangci-lint run --allow-parallel-runners\n- go build -ldflags "-w -s" -p=16 -o ./bytebase-build/bytebase ./backend/bin/server/main.go

@rebelice rebelice requested a review from a team as a code owner May 28, 2026 10:07
@cla-bot cla-bot Bot added the cla-signed label May 28, 2026
@rebelice rebelice enabled auto-merge (squash) May 28, 2026 10:11

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 6f6c5d8dda

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment thread backend/plugin/parser/plsql/omni.go Outdated
@rebelice rebelice force-pushed the codex/fix-oracle-omni-wrapper branch from 6f6c5d8 to fa38e2b Compare May 28, 2026 10:16

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: fa38e2bca2

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment thread backend/plugin/parser/plsql/omni.go Outdated
@rebelice rebelice force-pushed the codex/fix-oracle-omni-wrapper branch from fa38e2b to 8fec3fa Compare May 28, 2026 10:27
@rebelice rebelice merged commit a247a09 into main May 28, 2026
15 checks passed
@rebelice rebelice deleted the codex/fix-oracle-omni-wrapper branch May 28, 2026 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants