refactor(frontend): remove Vue bridges from project database detail by RainbowDashy · Pull Request #19924 · bytebase/bytebase

RainbowDashy · 2026-04-09T06:19:09Z

Summary

migrate the project database detail page panels off page-level Vue bridges and onto React-native overview, changelog, revision, catalog, and schema browser components
replace the remaining bridge-backed catalog and schema interactions with React dialogs/tables, including grant access, table detail, revision import, and schema browsing flows
expand the React page test coverage and add locale entries needed by the new database detail UI

Test Plan

CI=1 pnpm --dir frontend test --run src/react/pages/project/ProjectDatabaseDetailPage.test.tsx src/react/pages/project/database-detail/panels/DatabaseCatalogPanel.test.tsx
pnpm --dir frontend fix
pnpm --dir frontend check
pnpm --dir frontend type-check

Breaking Changes

the project database detail experience is now fully React-owned at the page level, and the previous Vue-backed schema diagram action has been replaced by a simplified React schema browser dialog

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 06e77442c3

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: c247f5be52

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: ede1f11ff1

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: faed0a2cb3

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: ac4425af54

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

sonarqubecloud · 2026-04-09T08:20:07Z

Quality Gate failed

Failed conditions
37 New issues
8 Security Hotspots
3.1% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 6d118e91bd

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector · 2026-04-09T08:26:46Z

+      [
+        showSchemaColumn
+          ? { key: "schema", label: t("common.schema") }
+          : undefined,
+        { key: "name", label: t("common.name") },


Restore engine column for non-Postgres table rows

The new React TableMetadataTable builds its column set without an engine field, so non-Postgres databases (where table engine metadata is relevant, e.g. MySQL/MariaDB) no longer show per-table engine values that were previously visible in the legacy table flow. This is a functional regression in the overview tab for those engines and makes it harder to inspect storage-engine-dependent behavior; add a conditional engine column for non-Postgres engines to preserve prior metadata visibility.

Useful? React with 👍 / 👎.

* fix(frontend): restore database detail regression parity * fix(frontend): restore react table detail parity * fix(frontend): preserve revision import validation

RainbowDashy requested a review from a team as a code owner April 9, 2026 06:19

RainbowDashy added the breaking label Apr 9, 2026

cla-bot Bot added the cla-signed label Apr 9, 2026

d-bytebase requested a review from ecmadao April 9, 2026 06:21

d-bytebase approved these changes Apr 9, 2026

View reviewed changes

chatgpt-codex-connector Bot reviewed Apr 9, 2026

View reviewed changes

Comment thread frontend/src/react/pages/project/database-detail/panels/DatabaseCatalogPanel.tsx

Comment thread frontend/src/react/pages/project/database-detail/panels/DatabaseRevisionPanel.tsx Outdated

RainbowDashy removed the breaking label Apr 9, 2026

RainbowDashy added 10 commits April 9, 2026 14:46

docs: add database detail react migration design

6e22826

refactor(frontend): migrate database overview panel to react

648ddc5

test(frontend): remove vue scaffolding from overview panel test

01cc9de

fix(frontend): restore overview legacy behavior

cf8f39c

fix(frontend): restore overview panel parity

7a09e30

fix(frontend): restore overview panel query and loading parity

6a5f19d

refactor(frontend): migrate database history panels to react

7155db2

refactor(frontend): migrate database catalog panel to react

04e3c31

refactor(frontend): remove database detail vue bridges

59a348f

test(frontend): align database detail page test after rebase

c247f5b

RainbowDashy force-pushed the p0ny/fix-database-detail-page branch from 06e7744 to c247f5b Compare April 9, 2026 06:48

docs: add locale sorter design

f83a7ff

chatgpt-codex-connector Bot reviewed Apr 9, 2026

View reviewed changes

Comment thread frontend/src/react/pages/project/database-detail/catalog/GrantAccessDialog.tsx Outdated

Comment thread frontend/src/react/pages/project/database-detail/overview/DatabaseObjectExplorer.tsx Outdated

RainbowDashy added 6 commits April 9, 2026 15:01

feat(frontend): add locale sorter script

ab320b5

fix(frontend): avoid partial locale sorting writes

3da11a8

fix(frontend): rollback failed locale sort writes

36475dc

fix(frontend): restore current file on sort rollback

2eb8d7e

chore(frontend): run locale sorting during fix

5bced45

chore(frontend): validate locale sorting in check

ede1f11

chatgpt-codex-connector Bot reviewed Apr 9, 2026

View reviewed changes

Comment thread frontend/src/react/pages/project/database-detail/revision/CreateRevisionDialog.tsx

Comment thread frontend/src/react/pages/project/database-detail/overview/TableDetailDialog.tsx

RainbowDashy added 2 commits April 9, 2026 15:40

fix(frontend): address database detail review feedback

faed0a2

docs: add revision import parity design

a6e99bf

chatgpt-codex-connector Bot reviewed Apr 9, 2026

View reviewed changes

Comment thread frontend/src/react/pages/project/database-detail/catalog/SensitiveColumnTable.tsx Outdated

fix(frontend): restore inline catalog retagging

ac4425a

chatgpt-codex-connector Bot reviewed Apr 9, 2026

View reviewed changes

Comment thread frontend/src/react/pages/project/database-detail/panels/DatabaseRevisionPanel.tsx

fix(frontend): restore database detail overview table

6d118e9

RainbowDashy merged commit 79dd009 into main Apr 9, 2026
18 of 19 checks passed

RainbowDashy deleted the p0ny/fix-database-detail-page branch April 9, 2026 08:23

chatgpt-codex-connector Bot reviewed Apr 9, 2026

View reviewed changes

Uh oh!

Conversation

RainbowDashy commented Apr 9, 2026

Summary

Test Plan

Breaking Changes

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

sonarqubecloud Bot commented Apr 9, 2026

Quality Gate failed

Uh oh!

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector Bot Apr 9, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants