Timestamp with timezone fails to parse minutes - #309
Conversation
|
Could you whip up a regression test for this? Somewhere around here would be good: |
|
The test 'timestamptz with minutes in timezone' is already present. Should the value of property |
|
The test is passing for me before I merge this pull request so it's either not testing the right thing, or the test is incorrect. |
|
I am certain about following, pg returns timezone in hh:mm format. Timezone input in postgres is more lenient as mentioned in the docs: http://www.postgresql.org/docs/9.2/static/datatype-datetime.html#DATATYPE-DATETIME-INPUT. I did not find any reference to the timezone output format. http://www.w3.org/TR/NOTE-datetime document however is clear about the formats. It specifies TZD = time zone designator (Z or +hh:mm or -hh:mm). |
|
@ajitk I appreciate your help with this one. Sorry it took so long. I was confused on the failing tests, but I got it sorted out now. |
|
@brianc Thanks for the great work. You rock! |
|
😄 open source rocks! 🎸 💃 🎉 |
The timezone parser in text parser modules missed the
:that appears in timezone. As a result it failed to parse the minutes component of the timezone.