Fixing issue on Unix sockets in Native Binding - #179

This pull request passes (merged 6e0922a into ba733f5).

This pull request fails (merged eaa2ba1 into ba733f5).

This pull request passes (merged 663a965 into ba733f5).

This pull request fails (merged 66a63ad into ba733f5).

This pull request fails (merged 6b95d75 into ba733f5).

This pull request fails (merged 53f5036 into ba733f5).

This pull request fails (merged c921287 into ba733f5).

This pull request fails (merged 216dc41 into ba733f5).

This pull request fails (merged 62132ac into ba733f5).

hmm...would it be possible to squash your commits down into a single commit that passes the tests? Are you able to run the tests locally? If you need help running them I'll be glad to do what I can to get you up and running.

Sorry, for that, but all those commits aren't actually related to my
initial pull request regarding fixture of Unix socket support in
natively binding with pg.

I tried to reduce code on parsing responses then and obviously this
fixture is incomplete, yet. I'll have a look at it ... regarding
squashing commits I'm not much familiar with git, so any help would be
appreciated.

This pull request passes (merged 596f518 into ba733f5).

Sorry for committing to my fork w/o properly testing and while pull
request was in effect. Now the tests have passed.

BTW: Now I know my fault and won't do any further edits on master branch ever again. ;)

No worries - travis was going crazy. I didn't know pull requests worked like that either.

I assume you're ready for me to test your patch & merge it now? 😄

If you could, just make a new branch with only the unix socket fixes related and then do a pull request off of that branch?

The crazy train left this pull request's station long ago. I want to fix this. Circle back to me when you get the branching thang figured out.

I tried to figure out how to branch in git and on using github and
didn't quite succeed. Nevertheless the regarding patch is as easy as
making all that branching stuff oversized at all. So let's try doing it
the ancient way. The diff is available here:

soletan@6e0922a

I repeated my efforts to checkout your project using c9.io, branching
there, modifying the file according to that diff there, committing to
whatever repo and still don't know what to do then. push requests aren't
succeeding.

Best Regards,
Thomas Urban

toxA IT-Dienstleistungen - Thomas Urban
Walter-Friedländer-Straße 2
D-10249 Berlin

Design + Programmierung = DoppelPack
http://www.doppelpack-berlin.de

Am 11.09.2012 03:25, schrieb Brian C:

The crazy train left this pull request's station long ago. I want to fix
this. Circle back to me when you get the branching thang figured out.

—
Reply to this email directly or view it on GitHub
#179 (comment).

@brianc , any updates here? Seems UNIX sockets still don't work with pg's native bindings.

I think we need a test for this... @matinm could you think of adding a test case?