Fix: MarketMap not rendering and axis positioning in 0.13.0#1705
Merged
Conversation
- Rename map_margin to fig_margin in market_map.py and MarketMapModel.ts - Fix axis position by replacing this.width/this.height by this.plotareaWidth/this.plotareaHeight in MarketMap.ts
martinRenou
approved these changes
May 7, 2026
Member
martinRenou
left a comment
There was a problem hiding this comment.
Thanks for the PR! I'll try to make a patch release soon with this. It seems MarketMap is not tested at all on our pipeline
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a bug introduced after updating to 0.13.0 affecting the display of MarketMap figure and axis position.
Reproduce bug
On version 0.13.0, running cell 3 of notebook
examples/Marks/Object Model/Market Map.ipynbrenders blank. After fixing the rendering issue, cell 9 of the same notebook has axis mispositioned (see images below).References
None
Code changes
Rename
map_margintofig_marginin market_map.py and MarketMapModel.ts to match getter in Figure.tsFix axis position by replacing
this.width/this.heightwiththis.plotareaWidth/this.plotareaHeightin MarketMap.tsUser-facing changes
Before
After
Before
After
Backwards-incompatible changes
None