Skip to content

EXP: Bump pandas maxversion to v2#1587

Merged
martinRenou merged 4 commits intobqplot:masterfrom
pllim:patch-2
Apr 7, 2023
Merged

EXP: Bump pandas maxversion to v2#1587
martinRenou merged 4 commits intobqplot:masterfrom
pllim:patch-2

Conversation

@pllim
Copy link
Copy Markdown
Contributor

@pllim pllim commented Feb 23, 2023

Bump pandas maxversion to v2 and see how badly things break.

References

Code changes

See diff.

User-facing changes

N/A

Backwards-incompatible changes

N/A

@pllim

This comment was marked as resolved.

@martinRenou
Copy link
Copy Markdown
Member

Yes. The CI is not triggered because it does not touch files that are considered triggering the CI: https://github.com/bqplot/bqplot/blob/master/.github/workflows/build.yml#L11

This was introduced recently and it looks like we are missing some paths that are actually important :P

There are some paths to add here.

@pllim
Copy link
Copy Markdown
Contributor Author

pllim commented Feb 23, 2023

Now someone gotta approve it. Thanks for the help!

@maartenbreddels
Copy link
Copy Markdown
Member

Prediction: this doesn't fail, and we should not have pinned. Now we can never test older versions of bqplot with newer versions of pandas

famous last words.. ?

@pllim
Copy link
Copy Markdown
Contributor Author

pllim commented Feb 23, 2023

Actually, will the existing jobs even pick up pandas pre-release? How do I make it do that?

@maartenbreddels maartenbreddels marked this pull request as ready for review April 6, 2023 19:25
Copy link
Copy Markdown
Member

@martinRenou martinRenou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@martinRenou martinRenou merged commit 14528cb into bqplot:master Apr 7, 2023
@martinRenou
Copy link
Copy Markdown
Member

meeseeksdev please backport to master

@lumberbot-app
Copy link
Copy Markdown

lumberbot-app bot commented Apr 7, 2023

Can't Dooooo.... It seem like this is already backported (commit is empty).I won't do anything. MrMeeseeks out.

@martinRenou
Copy link
Copy Markdown
Member

meeseeksdev backport to 0.12.x ?

@lumberbot-app
Copy link
Copy Markdown

lumberbot-app bot commented Apr 7, 2023

Something went wrong ... Please have a look at my logs.

It seems that the branch you are trying to backport to does not exist.

@martinRenou
Copy link
Copy Markdown
Member

meeseeksdev backport to 0.12.x

@lumberbot-app
Copy link
Copy Markdown

lumberbot-app bot commented Apr 7, 2023

Something went wrong ... Please have a look at my logs.

@martinRenou
Copy link
Copy Markdown
Member

martinRenou pushed a commit to martinRenou/bqplot that referenced this pull request Apr 7, 2023
* EXP: Bump pandas maxversion to v2

and see how badly things break

* TST: Bump checkout version

* TST: Bump versions in build

* TST: Add paths to build for
@martinRenou
Copy link
Copy Markdown
Member

#1596

martinRenou added a commit that referenced this pull request Apr 7, 2023
* EXP: Bump pandas maxversion to v2

and see how badly things break

* TST: Bump checkout version

* TST: Bump versions in build

* TST: Add paths to build for

Co-authored-by: P. L. Lim <2090236+pllim@users.noreply.github.com>
@pllim pllim deleted the patch-2 branch April 7, 2023 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants