Skip to content

fix: panning in a by CSS rotated plot doesn't work correctly #1585

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
maartenbreddels merged 1 commit into from
Mar 28, 2023
Merged

fix: panning in a by CSS rotated plot doesn't work correctly #1585

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
45 changes: 42 additions & 3 deletions js/src/PanZoom.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,8 @@ import * as _ from 'underscore';

const nop = () => {};

const IS_CHROMIUM = navigator.userAgent.includes(' Chrome/');

export class PanZoom extends interaction.Interaction {
render() {
super.render();
Expand Down Expand Up @@ -99,8 +101,43 @@ export class PanZoom extends interaction.Interaction {
});
}

hasRotatedParent(element) {
const parent = element.parentNode;
/* Base case: the element has no parent or the parent is the <html> element */
if (!parent || parent.tagName === 'HTML') {
return false;
}

/* Check if the parent is rotated */
const computedStyle = window.getComputedStyle(parent);
const transform = computedStyle.getPropertyValue('transform');

if (transform !== 'none' && !transform.startsWith('matrix(1, 0, 0, 1')) {
return true;
}

/* Recursively check the parent's parent */
return this.hasRotatedParent(parent);
}

mousePos() {
if (this.use_css_rotation_workaround) {
const mouseEvent = window.event as MouseEvent;

/* the mouse position is only correct within this.el */
if (mouseEvent.target === this.el) {
this.last_mouse_pos = [mouseEvent.offsetX, mouseEvent.offsetY];
}
return this.last_mouse_pos;
} else {
return d3.mouse(this.el);
}
}

mousedown() {
this._mousedown(d3.mouse(this.el));
this.use_css_rotation_workaround =
!IS_CHROMIUM && this.hasRotatedParent(this.el);
this._mousedown(this.mousePos());
}

_mousedown(mouse_pos) {
Expand All @@ -125,7 +162,7 @@ export class PanZoom extends interaction.Interaction {
}

mousemove() {
this._mousemove(d3.mouse(this.el));
this._mousemove(this.mousePos());
}

_mousemove(mouse_pos) {
Expand Down Expand Up @@ -177,7 +214,7 @@ export class PanZoom extends interaction.Interaction {
const event = d3GetEvent();
event.preventDefault();
const delta = event.deltaY * -1;
const mouse_pos = d3.mouse(this.el);
const mouse_pos = this.mousePos();
this._zoom(mouse_pos, delta);
}
}
Expand Down Expand Up @@ -224,4 +261,6 @@ export class PanZoom extends interaction.Interaction {
scale_promises: any;
previous_pos: [number, number];
domains_in_order: { x: any[]; y: any[] };
last_mouse_pos = null;
use_css_rotation_workaround: boolean;
}