Skip to content

Fix luminowidget#1523

Merged
martinRenou merged 2 commits intobqplot:0.12.xfrom
martinRenou:fix_luminowidget
Sep 2, 2022
Merged

Fix luminowidget#1523
martinRenou merged 2 commits intobqplot:0.12.xfrom
martinRenou:fix_luminowidget

Conversation

@martinRenou
Copy link
Copy Markdown
Member

The luminoWidget accessor does not work undo ipywidgets 7

@martinRenou
Copy link
Copy Markdown
Member Author

meeseeksdev please backport to master

@lumberbot-app
Copy link
Copy Markdown

lumberbot-app bot commented Sep 2, 2022

Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

  1. Checkout backport branch and update it.
git checkout master
git pull
  1. Cherry pick the first parent branch of the this PR on top of the older branch:
git cherry-pick -x -m1 00d0aa43f46d8b0929389d32ac20a0cc9e4a1133
  1. You will likely have some merge/cherry-pick conflict here, fix them and commit:
git commit -am 'Backport PR #1523: Fix luminowidget'
  1. Push to a named branch:
git push YOURFORK master:auto-backport-of-pr-1523-on-master
  1. Create a PR against branch master, I would have named this PR:

"Backport PR #1523 on branch master (Fix luminowidget)"

And apply the correct labels and milestones.

Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon!

Remember to remove the Still Needs Manual Backport label once the PR gets merged.

If these instructions are inaccurate, feel free to suggest an improvement.

@martinRenou martinRenou merged commit 1025711 into bqplot:0.12.x Sep 2, 2022
@martinRenou martinRenou deleted the fix_luminowidget branch September 2, 2022 14:53
martinRenou added a commit that referenced this pull request Sep 2, 2022
Forward port #1523 Fix pWidget accessor in the case of ipywidgets 7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant