Add default color CSS selectors to node text#1447
Merged
martinRenou merged 4 commits intobqplot:masterfrom Feb 10, 2022
Merged
Conversation
Member
Author
|
update galata references |
Signed-off-by: Itay Dafna <idafna@seas.upenn.edu>
96d6387 to
7f06baa
Compare
Member
Author
|
update galata references |
martinRenou
reviewed
Feb 10, 2022
Member
Author
|
I intentionally changed the text color of the nodes so that the text is
still visible if the text exceeds the bounds of the node's radius on the
dark theme. Otherwise it has the same color as the background and makes it
impossible to read.
…On Thu, Feb 10, 2022, 00:20 martinRenou ***@***.***> wrote:
***@***.**** commented on this pull request.
Looking at the visual diffs, this has an impact on the text color *in*
nodes, should we keep the text in nodes black?
—
Reply to this email directly, view it on GitHub
<#1447 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AFZICWOKIVR32KLQLLJUDVTU2NYNRANCNFSM5M4SSG4A>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Member
|
Makes sense, thanks! |
Member
|
meeseeksdev please backport to 0.12.x |
|
Owee, I'm MrMeeseeks, Look at me. There seem to be a conflict, please backport manually. Here are approximate instructions:
And apply the correct labels and milestones. Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon! Remember to remove the If these instructions are inaccurate, feel free to suggest an improvement. |
martinRenou
pushed a commit
to martinRenou/bqplot
that referenced
this pull request
Feb 10, 2022
* Add default color CSS selectors to node text Signed-off-by: Itay Dafna <idafna@seas.upenn.edu> * Run lint * Update Galata References * Update Galata References Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Member
|
meeseeksdev please backport to 0.12.x |
meeseeksmachine
pushed a commit
to meeseeksmachine/bqplot
that referenced
this pull request
Feb 10, 2022
martinRenou
added a commit
that referenced
this pull request
Feb 10, 2022
…7-on-0.12.x Backport PR #1447 on branch 0.12.x (Add default color CSS selectors to node text)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Itay Dafna idafna@seas.upenn.edu
Add node_text_color traitlet to Graph object(will do this in a separate PR)Visual regressions tests will likely need to be updated for Node objects as default text color for dark theme is now lighter.