Skip to content

chore: fix deprecation warnings/issues and let pytest catch them#1406

Merged
martinRenou merged 1 commit intobqplot:masterfrom
maartenbreddels:chore_no_deprecation_warnings
Sep 30, 2021
Merged

chore: fix deprecation warnings/issues and let pytest catch them#1406
martinRenou merged 1 commit intobqplot:masterfrom
maartenbreddels:chore_no_deprecation_warnings

Conversation

@maartenbreddels
Copy link
Copy Markdown
Member

This will clean up not only our test output, but also others, we only got one left from traittypes now:

$ py.test tests --pdb                         jdaviz-dev
=============================== test session starts ================================
platform darwin -- Python 3.7.10, pytest-6.1.2, py-1.10.0, pluggy-0.13.1
rootdir: /Users/maartenbreddels/src/bqplot, configfile: pytest.ini
plugins: asdf-2.8.0, anyio-3.0.1
collected 10 items                                                                 

tests/binary_serialization_test.py .....                                     [ 50%]
tests/marks_test.py ....                                                     [ 90%]
tests/selector_test.py .                                                     [100%]

================================= warnings summary =================================
../../miniconda3/envs/jdaviz-dev/lib/python3.7/site-packages/traittypes/traittypes.py:24
  /Users/maartenbreddels/miniconda3/envs/jdaviz-dev/lib/python3.7/site-packages/traittypes/traittypes.py:24: DeprecationWarning: 
              Sentinel is not a public part of the traitlets API.
              It was published by mistake, and may be removed in the future.
              
    """)

-- Docs: https://docs.pytest.org/en/stable/warnings.html
========================== 10 passed, 1 warning in 0.19s ===========================

@martinRenou martinRenou force-pushed the chore_no_deprecation_warnings branch from d62a9b3 to ff4fb1c Compare September 30, 2021 15:23
@martinRenou
Copy link
Copy Markdown
Member

Rebased, the CI should pass now

@martinRenou
Copy link
Copy Markdown
Member

@meeseeksdev please backport to 0.12.x

meeseeksmachine pushed a commit to meeseeksmachine/bqplot that referenced this pull request Sep 30, 2021
@martinRenou martinRenou merged commit 37ea0ec into bqplot:master Sep 30, 2021
@martinRenou martinRenou deleted the chore_no_deprecation_warnings branch September 30, 2021 15:48
martinRenou added a commit that referenced this pull request Sep 30, 2021
…6-on-0.12.x

Backport PR #1406 on branch 0.12.x (chore: fix deprecation warnings/issues and let pytest catch them)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants