Move WebGL Marks in a separate package#1389
Conversation
aec46ca to
607abb2
Compare
c0d34d1 to
dacff09
Compare
c3c0d24 to
a6a038a
Compare
|
PR tested with https://github.com/bqplot/bqplot-gl in bqplot/bqplot-gl#7 (adding visual tests with Galata and current JS tests soon) |
a6a038a to
1a9e036
Compare
|
What about creating a webgl canvas, and letting the marks create a threejs renderer if needed? |
|
@maartenbreddels thanks for the review :)
What would be the upside of this? |
|
Most of the code in the Figure class can stay as it is (only the line/lines that creates the rendered will change), and we don't need any Figure subclass. |
|
Right! Yeah that would be cool. I'll try it this way then. |
|
This means you can write a threejs, raw WebGL, or Regl marks and mix them. |
728a8aa to
f5a122a
Compare
|
@maartenbreddels the webgl context is now created here in bqplot and we don't need to subclass the Figure |
|
Yes, very cool! |
177a357 to
3b6e2a3
Compare
3b6e2a3 to
87a8a1b
Compare
This should be resolved now :) |
Move WebGL marks to the bqplot-gl package