Merged
Conversation
84f9a78 to
d0823c1
Compare
Member
Author
|
Support seems good https://developer.mozilla.org/en-US/docs/Web/API/Element/wheel_event |
This cleans up all the event handlers and uses the now standard 'wheel' event, which has as by effect that the page does not scroll anymore with firefox.
d0823c1 to
af49f5d
Compare
This comment has been minimized.
This comment has been minimized.
Member
|
yay! |
Contributor
|
I wanted to test this but unable to install from source. I use I guess I'll just have to trust you and wait for a release. Thanks! |
This was referenced May 11, 2021
Member
Author
|
I think downgrading nodejs should work. Maybe try a few major versions back.
(from mobile phone)
…On Tue, May 11, 2021, 18:34 P. L. Lim ***@***.***> wrote:
I wanted to test this but unable to install from source. I use conda to
install nodejs and I don't see any upgrade available.
error ***@***.***: The engine "node" is incompatible with this module. Expected version ">=10.17.0". Got "10.13.0"
error Found incompatible module.
I guess I'll just have to trust you and wait for a release. Thanks!
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#1347 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AANPEPKFRVRQYTX2XXJ7M33TNFL7ZANCNFSM44VOXPMQ>
.
|
Contributor
|
Instead of messing with nodejs, I got something to install by hacking your diff --git a/js/yarn.lock b/js/yarn.lock
index ace7b2fb..c7f003d3 100644
--- a/js/yarn.lock
+++ b/js/yarn.lock
@@ -3756,7 +3756,6 @@ execa@^5.0.0:
dependencies:
cross-spawn "^7.0.3"
get-stream "^6.0.0"
- human-signals "^2.1.0"
is-stream "^2.0.0"
merge-stream "^2.0.0"
npm-run-path "^4.0.1"Not sure why the version isn't reporting "dev" and also zoom still does not work for me. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes #1304 and fixes #81 (Whow, that's an oldie!)