Merged
Conversation
239c671 to
0d66984
Compare
0d66984 to
dbf4bcc
Compare
Closed
jwerle
approved these changes
Dec 18, 2019
Member
|
LGTM! |
Contributor
Author
|
@jwerle Hey! Will it be merged eventually? |
Contributor
Author
|
Thanks! |
Member
|
no problem! |
This was referenced Jan 15, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR installs bpkg and the packages installed globally in
/usr/local/binif run as root and in$HOME/.local/binif run as a user.As there is not test framework integrated, I checked the following cases:
The PREFIX value is passed as environment variable to the build command of packages.json or to make install