Supported choosing asset_id to fee for simple transfer - #56
Merged
Conversation
Member
|
Thanks for the PR. I would like to make a request that is pretty easy to implement and enables all calls to use a different fee asset.
That way, all calls can make use of this feature without even touching them. |
Contributor
Author
|
Hi @xeroc, thanks for your advice, and I have updated. |
Codecov Report
@@ Coverage Diff @@
## master #56 +/- ##
=========================================
Coverage ? 68.15%
=========================================
Files ? 50
Lines ? 3925
Branches ? 0
=========================================
Hits ? 2675
Misses ? 1250
Partials ? 0
Continue to review full report at Codecov.
|
Member
|
Excellent work! Thank you for your contribution! |
xeroc
added a commit
that referenced
this pull request
Mar 23, 2018
Release 0.1.13 77b651b (HEAD -> master) Merge branch 'release/0.1.13' 5346039 (release/0.1.13) version bump 458c293 remove ropeproject files 425eaa2 (develop) bump dependency on graphenelib 7687bec (origin/develop) [account] improve history generator f79a3a4 [docs] improve index.rst c5fcacb fix wrong derivation of collateral 806af6d Properly set heritance 0d72150 [chache] fix clearing of cache 4418a6a Properly load new wallet class 6fd5d59 merge improvements from python-peerplays f6d22eb Catch account_create exception 138ba18 fix #59 5ca5ee1 Merge pull request #56 from brickgao/dev c42d689 [bitsharesapi] allow to define list of API nodes with , or ; fb40617 supported all calls to use a different fee asset 732d7d2 supported selecting asset_id to fee for simple transfer
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#22