Add the ability to close the websocket connection - #41
Merged
Conversation
This reverts commit d46d526.
Use threading.Event to close the thread more easily
xeroc
added a commit
that referenced
this pull request
Mar 14, 2018
Release 0.1.12 9250544 (HEAD -> master) Merge branch 'release/0.1.12' 8e34bbc (release/0.1.12) version bump eba7742 (develop) fix linting 40bd616 (origin/develop) Merge pull request #48 from HarukaMa/patch-1 0b2a89c Merge pull request #57 from blockchainprojects/fix_blockchain_monitor 355e89b fixes blockchain block listener 4364164 [wallet] Allow to wipe the keys and masterkey without knowledge of the masterpasword 0b41559 Allow to use https:// endpoints via REST HTTP 935bf19 fix proposer signing 596e88e Use proposer to sign a proposal and not the account 85eca5f Manually specify tz on parsed time from blockchain fd2e8aa [instance] set shared config 358413c fix #42 8a556c0 [operation] allow to create a new committee member with pybitshares 7dba22e Add withdraw_permission_create bca74f2 Merge pull request #41 from mikakoi/closing-socket-connection 47a7e94 [docs] Updated docs and build process for docs 02add28 [docs] use sphinx-api to generate bitshares.rst 1714fdc [Makefile] create docs via makefile eef3d43 [travis] try fix a bug that causes tests to break 55c5330 README - updates to add some badges 44a9a15 [logo] pybitshares logo 904813f Change websocket ping thread closing to be more responsive 8280ae8 Revert "Version bump" d46d526 Version bump cb8dc20 Add the ability to close the websocket connection
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will add method close() to the websocket module, which will close the websocket connection and wait for the ping thread to close.
This will also add keep_alive parameter to the notify module to adjust the ping interval.