This repository was archived by the owner on Aug 21, 2025. It is now read-only.
fix tox build and tests - #20
Merged
Merged
Conversation
kornpow
force-pushed
the
build/fix-tests
branch
2 times, most recently
from
July 1, 2022 17:55
50d267c to
7d088eb
Compare
Member
|
I think your PR is made against an older version of |
kornpow
force-pushed
the
build/fix-tests
branch
2 times, most recently
from
July 15, 2022 16:04
ae5b2f8 to
73678b3
Compare
Contributor
Author
|
@thunderbiscuit Ive pulled in the |
kornpow
force-pushed
the
build/fix-tests
branch
2 times, most recently
from
July 15, 2022 16:21
5ea1fa3 to
24f5a41
Compare
Contributor
Author
|
I was doing a few things to the tests, but it appears like |
thunderbiscuit
approved these changes
Jul 19, 2022
thunderbiscuit
left a comment
Member
There was a problem hiding this comment.
Looking good! I still have some questions regarding the manifest and the pyproject.toml but that's mostly because I don't have a ton of experience building Python packages as of yet. I followed up on Discord.
kornpow
commented
Aug 4, 2022
Signed-off-by: Sam Korn <korn94sam@gmail.com>
kornpow
force-pushed
the
build/fix-tests
branch
from
August 4, 2022 18:13
24f5a41 to
4396eba
Compare
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Sam Korn korn94sam@gmail.com
Note:
Description
Notes to the reviewers
Im a little confused about this line, and the requirement for
junkChecklists
All Submissions:
New Features:
CHANGELOG.md