Adding language support to GetStreamFilter in api.py. Also added the example for that. - #401
Conversation
…Also added the corresponding example for use.
…nd changed a comment in the newly added streaming example
Current coverage is 74.20% (diff: 0.00%)@@ master #401 diff @@
==========================================
Files 8 8
Lines 1971 1973 +2
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
Hits 1464 1464
- Misses 507 509 +2
Partials 0 0
|
|
Looks pretty good! A couple things I'd like to see:
Let me know what you think on # 2. |
|
(Don't worry about the code coverage thing - that function isn't tested yet anyway.) |
|
Looks great! Thanks for your help! @bear you good with this? |
|
Reviewed 2 of 3 files at r2. twitter/api.py, line 4455 at r2 (raw file):
my only quibble is that the new parameter be added to the end because we are doing this in a point release. if we add it into the middle of the parameter list then we break anyone who doesn't use named parameters in their calls. Comments from Reviewable |
|
Crap, I did the same thing with PostStatus in #394 |
|
@jeremylow ugh, sorry for not catching that! the benefit of smaller sized PRs |
|
Yep. I'll fix it on |
|
Speaking of develop, I just noticed this is going into the master branch, so I switched it to get integrated with the rest of the changes for 3.2. |
|
with that param change i'm +1 on merging - nicely done! |
|
Awesome. Merged! Thanks @chaitanya0411 and congrats on your first PR! |
|
Thanks guys ! It was a good experience ! |
see PR #401 for brief discussion.
This is my first contribution to somebody else's repository, so please pardon me if I have made some blunder :)
This change is