This repository was archived by the owner on Aug 7, 2024. It is now read-only.
Add support for non-ascii filenames in UploadMediaChunked - #389
Merged
Conversation
Current coverage is 74.27% (diff: 100%)@@ master #389 diff @@
==========================================
Files 8 8
Lines 1971 1971
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
Hits 1464 1464
Misses 507 507
Partials 0 0
|
Collaborator
Author
|
Another option would be to just name the file some ASCII string since I don't think it's ever exposed by Twitter, but this works just as well and is consistent with how we represent non-ASCII characters for py2 in |
Owner
|
Reviewed 2 of 2 files at r1. Comments from Reviewable |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change is