Skip to content
This repository was archived by the owner on Aug 7, 2024. It is now read-only.

Add User object to DMs per Issue #344 - #384

Merged
bear merged 3 commits into
masterfrom
fix/issue344
Sep 14, 2016
Merged

Add User object to DMs per Issue #344#384
bear merged 3 commits into
masterfrom
fix/issue344

Conversation

@jeremylow

@jeremylow jeremylow commented Sep 14, 2016

Copy link
Copy Markdown
Collaborator

Description

Adds a full-hydrated User object to the DirectMessage object for the sender and recipient properties.

Related Issue

#344

How Has This Been Tested?

Tests added for DirectMessage Model. All prior tests pass.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

This change is Reviewable

@bear

bear commented Sep 14, 2016

Copy link
Copy Markdown
Owner

Reviewed 3 of 3 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

@bear
bear merged commit 0aabee0 into master Sep 14, 2016
@bear
bear deleted the fix/issue344 branch September 14, 2016 15:41
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants