This repository was archived by the owner on Aug 7, 2024. It is now read-only.
tweet_volume not being populated for Trend objects - #375
Merged
Conversation
Current coverage is 69.15% (diff: 100%)@@ master #375 diff @@
==========================================
Files 8 8
Lines 2018 2020 +2
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
+ Hits 1395 1397 +2
Misses 623 623
Partials 0 0
|
Owner
|
Reviewed 3 of 4 files at r1, 1 of 1 files at r2. Comments from Reviewable |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Trend.volumedata should be populated on object creation, but because the json data from Twitter is namedtweet_volume, this isn't occurring. This changes the property name to betweet_volumewhich conforms with Twitter's naming convention and allows the property to be populated straight from the json data.Additionally, an
@propertyhas been added to theTrendobject for backwards compatibility.Related Issue
#374
Types of changes
Checklist:
This change is