This repository was archived by the owner on Aug 7, 2024. It is now read-only.
fix issue 358 - #370
Merged
Merged
Conversation
Owner
|
Reviewed 3 of 3 files at r1. Comments from Reviewable |
Owner
|
👍 - I like that this allows a saner default for this one use case |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds ability to set rate limit endpoints even if
api.sleep_on_rate_limitis FalseBasically, if you instantiate an Api instance with
sleep_on_rate_limit=False, then previously we would not keep track of the data returned in the headers that pertained to the rate limit. My thinking is that there could be a use case where you don't want the Api to sleep for 15 minutes (the default behavior when you're rate limited), but would rather have the program do something else.This change has the Api keep track of the rate limit status of any endpoint that the user specifically calls, but won't, on its own, go out and obtain the full rate limit endpoint and doesn't force the user into the default sleeping behavior.
This change is