This repository was archived by the owner on Aug 7, 2024. It is now read-only.
Fix/issue345 - #347
Merged
Merged
Conversation
Collaborator
Author
|
There's also an adorable corgi GIF, so I think my work here is done. |
Owner
|
Reviewed 5 of 5 files at r1. Comments from Reviewable |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes three issues:
python27 doesn't have a
bytes()method that's compatible with python3'sbytes()method, so I had to change to"a string".encode('utf8')for constructing the body of a chunked upload (i.e., a GIF or MP4).The UploadMediaChunked() method was pretty much untestable in its previous form and did way too much within a single function, so it is now broken out into three functions:
a.
_UploadMediaChunkedInit()<- starts the uploadb.
_UploadMediaChunkedAppend()<- sends actual datac.
_UploadMediaChunkedFinalize()<- finishes the uploadThese get called in sequence in
UploadMediaChunked()and that method is called and returns as before, but now we can test the individual parts of the upload.Calling
PostUpdate()tried to iterate over anintif you called it withmedia=fp, so that got fixed too.This change is