Skip to content
This repository was archived by the owner on Aug 7, 2024. It is now read-only.

setup environment to be more modern; tweak Makefile; convert to CircleCI - #308

Merged
bear merged 10 commits into
masterfrom
circleci-and-update-setup-environment
Mar 17, 2016
Merged

setup environment to be more modern; tweak Makefile; convert to CircleCI#308
bear merged 10 commits into
masterfrom
circleci-and-update-setup-environment

Conversation

@bear

@bear bear commented Mar 16, 2016

Copy link
Copy Markdown
Owner

This change is Reviewable

@jeremylow

Copy link
Copy Markdown
Collaborator

Would it be possible to add py3.5 to the tests? Currently only testing against 2.7.10.

@bear

bear commented Mar 16, 2016

Copy link
Copy Markdown
Owner Author

yes, will be adding them once I get everything looked at and +1'd from you for these changes

@jeremylow

Copy link
Copy Markdown
Collaborator

Looks good to me! The base commit from master is back a ways, but I assume that won't be a problem once merged.


Reviewed 13 of 13 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved, some commit checks failed.


Comments from the review on Reviewable.io

@bear

bear commented Mar 16, 2016

Copy link
Copy Markdown
Owner Author

nope, the master differences was me forgetting to merge forward :)

merged with master and tweaked those things you had fixed that I broke (again) - thanks!

@bear

bear commented Mar 17, 2016

Copy link
Copy Markdown
Owner Author

@jeremylow I think I have covered the master merge issues and this should be ready to merge

@jeremylow

Copy link
Copy Markdown
Collaborator

Good to go from me.


Review status: 8 of 14 files reviewed at latest revision, all discussions resolved.


Comments from the review on Reviewable.io

@jeremylow

Copy link
Copy Markdown
Collaborator

Reviewed 4 of 4 files at r2, 2 of 3 files at r3.
Review status: all files reviewed at latest revision, all discussions resolved.


Comments from the review on Reviewable.io

@bear

bear commented Mar 17, 2016

Copy link
Copy Markdown
Owner Author

\o/ thanks!

bear added a commit that referenced this pull request Mar 17, 2016
setup environment to be more modern; tweak Makefile; convert to CircleCI
@bear
bear merged commit 80b747b into master Mar 17, 2016
@bear
bear deleted the circleci-and-update-setup-environment branch March 17, 2016 22:30
jeremylow added a commit that referenced this pull request Mar 20, 2016
@jeremylow jeremylow mentioned this pull request Mar 20, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants