Skip to content
This repository was archived by the owner on Aug 7, 2024. It is now read-only.

Update to LookupFriendship - #297

Merged
jeremylow merged 4 commits into
masterfrom
feature/friendship_update
Feb 13, 2016
Merged

Update to LookupFriendship#297
jeremylow merged 4 commits into
masterfrom
feature/friendship_update

Conversation

@jeremylow

Copy link
Copy Markdown
Collaborator

Per discussion on #290 , LookupFriendship can take either ints/strings/Users or lists of those for user_id or screen_name. Add tests and data for method.

In working on this, I noticed that Twitter returns some additional information on querying that endpoint. In addition to following and followed_by there is now:

  • following_received (your account is private, target user has requested to follow you),
  • following_requested (target user is private, you've requested to follow them),
  • muting and blocking (target user is muted or blocked by authenticated user).

Review on Reviewable

@bear

bear commented Feb 12, 2016

Copy link
Copy Markdown
Owner

+1 to this.

Can I give you a personal shoutout for those migration docs! I don't think I would have thought about providing them in such detail -- great job!

@jeremylow

Copy link
Copy Markdown
Collaborator Author

Thanks! And sure - that's totally fine.

jeremylow added a commit that referenced this pull request Feb 13, 2016
@jeremylow
jeremylow merged commit 139f251 into master Feb 13, 2016
@jeremylow
jeremylow deleted the feature/friendship_update branch February 13, 2016 14:59
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants