You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
@maxday why add a new unittest directory? There is already a test directory with a CMake file and all.
It seems to me that existing tests are integration tests (which requires a more complex infra to be able to run them with CodeBuild and the SDK).
This new repo will contain unit tests, with an extremely fast feedback loop. This will help testing the runtime at the function level, without any third party integration.
Does it make sense to you?
Can you think of a way to combine both tests?
That would help us use the same google-test library for both unit and integration tests. We can even use the same CMake file potentially with some flags to turn on/off the integration tests.
It's not ideal to we have two different sets of tests that use different versions of the testing library.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes:
gtestframework viaCMakeLists.txt(1.12.0)noop.dummy_test, as a first step for having unit tests in CI.clang-tidynot to complain on external testing dependenciesTesting:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.