fix: correct min version check and remove dead import - #41
Draft
Koan-Bot wants to merge 1 commit into
Draft
Conversation
- dist.ini max_target_perl was 5.010 but MIN_PERL_VERSION is 5.008. Test::MinimumVersion would miss accidental use of 5.010 features. - Remove unused threads import from perlstring.t (thread testing lives in t/threads.t).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Fixes dist.ini
max_target_perland removes dead code from perlstring.t.Why
[Test::MinimumVersion]hadmax_target_perl = 5.010but the declared MIN_PERL_VERSION is 5.008. This meansxt/release/minimum-version.twould not flag accidental use of 5.010-only features (e.g.//,say), silently breaking 5.008 support.The
threadsimport in perlstring.t was dead code — thread testing lives in t/threads.t.How
max_target_perlchanged from5.010to5.008in dist.iniBEGIN { eval { require threads; threads->import; } }from perlstring.tTesting
make testpasses. The min-version check will now correctly enforce 5.008 compatibility during author releases.🤖 Generated with Claude Code