Exclude structured_units.rst for erfa-dev by mhvk · Pull Request #18551 · astropy/astropy

mhvk · 2025-08-25T16:51:25Z

Description

This pull request is to address the failure from a recent update in erfa. Similar to #18549, but just avoids running the doctest with erfa-dev (which should be fine). Main advantage is that there is a note to undo...

By checking this box, the PR author has requested that maintainers do NOT use the "Squash and Merge" button. Maintainers should respect this when possible; however, the final decision is at the discretion of the maintainer that merges the PR.

github-actions · 2025-08-25T16:51:37Z

Thank you for your contribution to Astropy! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.

Do the proposed changes actually accomplish desired goals?
Do the proposed changes follow the Astropy coding guidelines?
Are tests added/updated as required? If so, do they follow the Astropy testing guidelines?
Are docs added/updated as required? If so, do they follow the Astropy documentation guidelines?
Is rebase and/or squash necessary? If so, please provide the author with appropriate instructions. Also see instructions for rebase and squash.
Did the CI pass? If no, are the failures related? If you need to run daily and weekly cron jobs as part of the PR, please apply the "Extra CI" label. Codestyle issues can be fixed by the bot.
Is a change log needed? If yes, did the change log check pass? If no, add the "no-changelog-entry-needed" label. If this is a manual backport, use the "skip-changelog-checks" label unless special changelog handling is necessary.
Is this a big PR that makes a "What's new?" entry worthwhile and if so, is (1) a "what's new" entry included in this PR and (2) the "whatsnew-needed" label applied?
At the time of adding the milestone, if the milestone set requires a backport to release branch(es), apply the appropriate "backport-X.Y.x" label(s) before merge.

mhvk · 2025-08-25T17:25:18Z

Hmm, this passed the relevant test, but not "load tox environments", for reasons that seem unrelated.

mhvk · 2025-08-26T00:06:45Z

@pllim - thanks, how can I not have seen that? Hopefully things still work, if not I'll check locally.

pllim · 2025-08-26T14:11:55Z

You might need to tag a new dev tag over at pyerfa or something because devdeps is picking up the following version and still failing:

pyerfa==2.0.1.7.dev18+gbd0276210

Also we pick up pyerfa-dev from https://pypi.anaconda.org/liberfa/simple so please make sure the dev wheel with new tag is pushed there before rerunning devdeps here. Thanks!

mhvk · 2025-08-26T14:49:23Z

Gee, where was my brain yesterday? Not only got the name wrong, as you noticed, but also the actual version number - 2.1.0.7 is the actual next release that is in development. Also, for some reason, v2.1.0.6 never got properly released (was relevant for infrastructure mostly, so no big deal, but I should have noticed it...). Anyway, hopefully things will now just work.

pllim · 2025-08-26T14:50:34Z

 dependencies = [
    "numpy>=1.24",
-    "pyerfa>=2.0.1.1",
+    "pyerfa>=2.0.1.1",  # For >=2.0.1.8, adjust structured_units.rst and doctest-requires


Suggested change

"pyerfa>=2.0.1.1", # For >=2.0.1.8, adjust structured_units.rst and doctest-requires

"pyerfa>=2.0.1.1", # For >=2.0.1.7, adjust structured_units.rst and doctest-requires

mhvk · 2025-08-26T15:03:54Z

Yikes, still not working. Will investigate locally.

mhvk · 2025-08-26T15:15:54Z

Dyslexia too, apparently... 2.1.0.7 or 2.0.1.7. Sigh.

pllim · 2025-08-26T15:24:30Z

2.1.0.7 or 2.0.1.7

Wow I missed that too!

mhvk · 2025-08-26T15:31:15Z

Looks like it passed now...

Co-authored-by: P. L. Lim <2090236+pllim@users.noreply.github.com>

mhvk · 2025-08-26T16:31:05Z

OK, done. Thanks, @pllim, and apologies for all the silly mistakes in a 2-line changed PR...

pllim

No worries. Thanks for the fix!

pllim · 2025-08-26T17:34:31Z

Actually maybe we should backport to future-proof the release branch CI

@meeseeksdev backport to v7.1.x

pllim · 2025-08-26T17:36:22Z

Hmm. Let me rerun devdeps on v7.1.x to make sure. (Yes, fails now, so we need the backport.)

* Exclude structured_units.rst for erfa-dev * Update pyproject.toml [skip ci] Co-authored-by: P. L. Lim <2090236+pllim@users.noreply.github.com> --------- Co-authored-by: P. L. Lim <2090236+pllim@users.noreply.github.com> (cherry picked from commit 674c737)

pllim · 2025-08-26T18:05:35Z

Manual backport at #18554

* Exclude structured_units.rst for erfa-dev * Update pyproject.toml Co-authored-by: P. L. Lim <2090236+pllim@users.noreply.github.com> --------- Co-authored-by: P. L. Lim <2090236+pllim@users.noreply.github.com> (cherry picked from commit 674c737)

Backport PR #18551 on branch v7.1.x (Exclude structured_units.rst for erfa-dev)

neutrinoceros · 2026-03-09T17:27:59Z

I'm running into the comment from this PR in #19380, and I don't think I understand the note at all... pyerfa 2.0.1.7 doesn't exist yet ? even 2.0.1.6 is in the future, so why was an hypothetical future version even mentioned ?

pllim · 2026-03-09T17:39:52Z

I think this was to future proof.

mhvk · 2026-03-10T00:35:33Z

It was to future proof indeed, with 2.0.1.7 meant to be the next release up. Looking at pyerfa, I see it has a 2.0.1.6 tag, but no corresponding release, so something went wrong there... Ouch... (Unfortunately, unable to deal with it now...).

mhvk added this to the v7.2.0 milestone Aug 25, 2025

mhvk added testing Affects-dev PRs and issues that do not impact an existing Astropy release erfa no-changelog-entry-needed labels Aug 25, 2025

github-actions bot added the installation label Aug 25, 2025

mhvk mentioned this pull request Aug 25, 2025

DOC/TST: adjust a doctest for compatibility with pyerfa-dev #18549

Closed

1 task

pllim reviewed Aug 25, 2025

View reviewed changes

Comment thread pyproject.toml Outdated

mhvk force-pushed the adjust-to-erfa-dev branch from f427ad0 to 207297c Compare August 26, 2025 14:47

pllim reviewed Aug 26, 2025

View reviewed changes

Exclude structured_units.rst for erfa-dev

0e051d9

mhvk force-pushed the adjust-to-erfa-dev branch from 207297c to 0e051d9 Compare August 26, 2025 15:14

neutrinoceros mentioned this pull request Aug 26, 2025

feat: Generic Table Conversion through Narwhals #18435

Merged

1 task

pllim reviewed Aug 26, 2025

View reviewed changes

Comment thread pyproject.toml Outdated

Update pyproject.toml [skip ci]

897e39a

Co-authored-by: P. L. Lim <2090236+pllim@users.noreply.github.com>

pllim approved these changes Aug 26, 2025

View reviewed changes

pllim merged commit 674c737 into astropy:main Aug 26, 2025
1 of 2 checks passed

pllim modified the milestones: v7.2.0, v7.1.1 Aug 26, 2025

pllim added the backport-v7.1.x label Aug 26, 2025

This comment was marked as resolved.

Sign in to view

lumberbot-app bot added the Still Needs Manual Backport label Aug 26, 2025

pllim mentioned this pull request Aug 26, 2025

Backport PR #18551 on branch v7.1.x (Exclude structured_units.rst for erfa-dev) #18554

Merged

1 task

pllim removed the Still Needs Manual Backport label Aug 26, 2025

mhvk deleted the adjust-to-erfa-dev branch August 26, 2025 18:22

pllim added a commit that referenced this pull request Aug 26, 2025

Merge pull request #18554 from pllim/backport-of-pr-18551-on-v7.1.x

c23e276

Backport PR #18551 on branch v7.1.x (Exclude structured_units.rst for erfa-dev)

mhvk mentioned this pull request Mar 10, 2026

The version 2.1.0.6 is tagged but not actually released liberfa/pyerfa#198

Open

neutrinoceros mentioned this pull request Mar 10, 2026

DOC: adapt to pyerfa >2.0.1.5 #19391

Open

	"pyerfa>=2.0.1.1", # For >=2.0.1.8, adjust structured_units.rst and doctest-requires
	"pyerfa>=2.0.1.1", # For >=2.0.1.7, adjust structured_units.rst and doctest-requires

Uh oh!

Conversation

mhvk commented Aug 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Uh oh!

github-actions bot commented Aug 25, 2025

Uh oh!

mhvk commented Aug 25, 2025

Uh oh!

Uh oh!

mhvk commented Aug 26, 2025

Uh oh!

pllim commented Aug 26, 2025

Uh oh!

mhvk commented Aug 26, 2025

Uh oh!

pllim Aug 26, 2025

Choose a reason for hiding this comment

Uh oh!

mhvk commented Aug 26, 2025

Uh oh!

mhvk commented Aug 26, 2025

Uh oh!

pllim commented Aug 26, 2025

Uh oh!

mhvk commented Aug 26, 2025

Uh oh!

Uh oh!

mhvk commented Aug 26, 2025

Uh oh!

pllim left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

pllim commented Aug 26, 2025

Uh oh!

This comment was marked as resolved.

pllim commented Aug 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pllim commented Aug 26, 2025

Uh oh!

neutrinoceros commented Mar 9, 2026

Uh oh!

pllim commented Mar 9, 2026

Uh oh!

mhvk commented Mar 10, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

mhvk commented Aug 25, 2025 •

edited

Loading

pllim commented Aug 26, 2025 •

edited

Loading