[ZEPPELIN-6051] Skip the hidden files in notebook listing (reopen) - #4792
Merged
Conversation
Convert "\n" (newline characters) to HTML line breaks in error popups messages.
This reverts commit ab4b99b.
Reamer
approved these changes
Aug 14, 2024
Contributor
|
If no further comments are received, I will merge this pull request on Thursday. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this PR for?
This PR reopens #4789. It was accidentally closed while resolving conflicts. @Reamer
This PR modifies the notebook listing logic to exclude hidden files that start with
..This is because showing non-executable files, such as meta files, could confuse users, as seen in this issue ZEPPELIN-6051.
Additionally I have enhanced the error popup message to be more specific, which appears when a user opens a notebook with parsing errors. I think it would be more helpful for users to recognize and resolve the issues on their own.
What type of PR is it?
What is the Jira issue?
How should this be tested?
Screenshots (if appropriate)
as-is
to-beto-be
Questions: