Merged
Conversation
iffyio
reviewed
Apr 17, 2026
Comment on lines
+2530
to
+2531
| /// Optional PartiQL index alias declared with `AT`. | ||
| pub at: Option<Ident>, |
Contributor
There was a problem hiding this comment.
Can we add a link to the doc defining the syntax? (maybe an example syntax would also be helpful like we have on the explicit field)
iffyio
reviewed
Apr 17, 2026
|
|
||
| #[test] | ||
| fn test_partiql_from_alias_with_at_index() { | ||
| redshift().verified_stmt("SELECT * FROM lineitem AS l (a, b, c) AT idx"); |
Contributor
There was a problem hiding this comment.
for the test can we switch to all_dialect_where(|d| d.supports_partiql()) so that future dialects are covered without duplicating tests?
fe58eb4 to
cca9fc7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add support for the
ATkeyword in PartiQL that is used during unnesting to retrieve the index of an element in an array.For example: