Skip to content

Add sphinx and sphinx-intl to requirements.txt - #350

Closed
jbampton wants to merge 1 commit into
apache:mainfrom
jbampton:update-requirements
Closed

Add sphinx and sphinx-intl to requirements.txt#350
jbampton wants to merge 1 commit into
apache:mainfrom
jbampton:update-requirements

Conversation

@jbampton

@jbampton jbampton commented Sep 26, 2023 •
edited
Loading

Copy link
Copy Markdown
Member

You will need to have sphinx and sphinx-intl installed to run the make commands successfully

@jbampton jbampton changed the title Add sphinx to requirements.txt Add sphinx and sphinx-intl to requirements.txt Sep 26, 2023
@DaanHoogland

DaanHoogland commented Sep 28, 2023

Copy link
Copy Markdown
Contributor

@jbampton , the doc builds have been succesful so far (not with me locally but the blueorangutan runs). When did you encounter that these are needed?

@jbampton

jbampton commented Sep 28, 2023

Copy link
Copy Markdown
Member Author

Hey @DaanHoogland basically I just went to setup this repo and run the make commands.

I created a fresh "cloudstack" Python virtual environment and then installed the requirements.txt file.

Then tried running the make commands from the README.

Shown in the image below:

Screenshot from 2023-09-28 21-19-25

@jbampton
jbampton requested a review from yadvr September 28, 2023 11:26
@shwstppr shwstppr added this to the 4.19 milestone Sep 29, 2023
@weizhouapache

weizhouapache commented Nov 15, 2023

Copy link
Copy Markdown
Member

@jbampton @DaanHoogland
we use readthedocs.org to build the documents for releases and latest branch.
the sphinx and other sphinx packages are automatially installed there.
However, the builds failed since one month ago, due the imcompatilibity of docutils-0.17.1 and sphinx 8.2.6

@jbampton Have you tested this PR with sphinx 8.2.6 ?

@weizhouapache
weizhouapache marked this pull request as draft November 15, 2023 09:00
@weizhouapache

weizhouapache commented Nov 15, 2023

Copy link
Copy Markdown
Member

@jbampton
I moved this PR to draft. If you have tested your PR in ubuntu 22.04, please feel free to move this to 'ready for review'

@weizhouapache

weizhouapache commented Nov 16, 2023

Copy link
Copy Markdown
Member

this has been addressed in #358

@jbampton
jbampton deleted the update-requirements branch November 16, 2023 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yadvr yadvr Awaiting requested review from yadvr

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

4.19

Development

Successfully merging this pull request may close these issues.

4 participants

@jbampton @DaanHoogland @weizhouapache @shwstppr