Skip to content

docs: Update instructions for adding DEB repository - #320

Merged
weizhouapache merged 1 commit into
apache:mainfrom
CLDIN:deb-repo
Sep 18, 2023
Merged

docs: Update instructions for adding DEB repository#320
weizhouapache merged 1 commit into
apache:mainfrom
CLDIN:deb-repo

Conversation

@wido

@wido wido commented May 31, 2023

Copy link
Copy Markdown
Contributor

apt-key and apt-get are deprecated. This PR makes use of the proper commands

apt-key is deprecated and so is apt-get. Replace this with the proper commands
Comment thread source/installguide/management-server/_pkg_repo.rst

@yadvr yadvr left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, left one suggestion


.. parsed-literal::

wget -O - http://download.cloudstack.org/release.asc |sudo apt-key add -

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suppose you tested this doesn't screw up the FDs for input and output (and maybe error) when it asks for pw, or screws up the file rights on cloudstack.asc?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have tested this and it worked on the Ubuntu 22.04 systems I tested this on

@DaanHoogland

Copy link
Copy Markdown
Contributor

one more thing @wido do we need this on the 4.18 branch?

@yadvr
yadvr changed the base branch from main to 4.18 September 14, 2023 10:37
@yadvr
yadvr changed the base branch from 4.18 to main September 14, 2023 10:37

@weizhouapache weizhouapache left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code lgtm

@weizhouapache
weizhouapache merged commit 8a5ca47 into apache:main Sep 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants