UI: Fix user role login due to missing API access on custom hypervisor name by nvazquez · Pull Request #7939 · apache/cloudstack

nvazquez · 2023-09-04T17:44:26Z

Description

This PR fixes the user role login in the UI on the main branch, bug introduced by the PR: #7692

Types of changes

Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change which adds functionality)
Bug fix (non-breaking change which fixes an issue)
Enhancement (improves an existing feature and functionality)
Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Major
Minor

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

As administrator, add 'Custom' to the 'hypervisor.list'
Restart management server
Create a Custom hypervisor zone
Attempt login as a user -> verify it works
As a user check the custom hypervisor is listed as a hypervisor on the new zone when trying to register a template

…r name

shwstppr

@nvazquez normal user may not have listConfigurations API access. Is this to bypass that?

nvazquez · 2023-09-04T18:02:51Z

@shwstppr yes, in case they don't have access then we set the default name for the Custom hypervisor

shwstppr · 2023-09-04T18:23:07Z

@shwstppr yes, in case they don't have access then we set the default name for the Custom hypervisor

@nvazquez in that case a normal user will always see custom hypervisor as Custom even though the admin has set some display name. Not sure if the value is used in UI/API. Would it be better to return the config value as a response param of listCapabilities API?

nvazquez · 2023-09-04T18:29:42Z

@shwstppr good idea, let me fix that

…e of listCapabilities API

nvazquez · 2023-09-04T18:38:20Z

@blueorangutan package

blueorangutan · 2023-09-04T18:40:03Z

@nvazquez a [SF] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

codecov · 2023-09-04T19:38:59Z

Codecov Report

Merging #7939 (856f7b6) into main (2e6100d) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

❗ Current head 856f7b6 differs from pull request most recent head 75f7d14. Consider uploading reports for the commit 75f7d14 to get more accurate results

@@             Coverage Diff              @@
##               main    #7939      +/-   ##
============================================
- Coverage     14.40%   14.40%   -0.01%     
+ Complexity    10111    10109       -2     
============================================
  Files          2748     2748              
  Lines        259390   259391       +1     
  Branches      40381    40381              
============================================
- Hits          37365    37358       -7     
- Misses       217190   217202      +12     
+ Partials       4835     4831       -4

Files Changed	Coverage Δ
...in/java/com/cloud/server/ManagementServerImpl.java	`5.37% <0.00%> (-0.01%)`	⬇️

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

blueorangutan · 2023-09-04T19:39:07Z

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 6975

nvazquez · 2023-09-04T19:44:48Z

@blueorangutan test

blueorangutan · 2023-09-04T19:46:03Z

@nvazquez a [SF] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

blueorangutan · 2023-09-05T08:37:59Z

[SF] Trillian test result (tid-7628)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 44819 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr7939-t7628-kvm-centos7.zip
Smoke tests completed. 113 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File

shwstppr

Code LGTM

yadvr

LGTM - didn't test it

nvazquez · 2023-09-06T13:20:08Z

@blueorangutan package

blueorangutan · 2023-09-06T13:22:07Z

@nvazquez a [SF] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2023-09-06T14:09:28Z

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 6990

nvazquez · 2023-09-06T14:24:25Z

@blueorangutan test

blueorangutan · 2023-09-06T14:26:03Z

@nvazquez a [SF] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

blueorangutan · 2023-09-07T03:34:33Z

[SF] Trillian test result (tid-7642)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 45812 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr7939-t7642-kvm-centos7.zip
Smoke tests completed. 112 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_05_vmschedule_test_e2e	`Failure`	265.92	test_vm_schedule.py

…r name (apache#7939) * UI: Fix user role login due to missing API access on custom hypervisor name * Refactor to include the custom HW display name as part of the response of listCapabilities API * Add since parameter (cherry picked from commit 940733c) Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

UI: Fix user role login due to missing API access on custom hyperviso…

7489671

…r name

nvazquez added type:bug component:UI labels Sep 4, 2023

nvazquez added this to the 4.19.0.0 milestone Sep 4, 2023

nvazquez requested review from DaanHoogland, Pearl1594, harikrishna-patnala, shwstppr, vishesh92, weizhouapache and yadvr September 4, 2023 17:44

shwstppr reviewed Sep 4, 2023

View reviewed changes

Refactor to include the custom HW display name as part of the respons…

856f7b6

…e of listCapabilities API

boring-cyborg Bot added component:api component:management-server labels Sep 4, 2023

harikrishna-patnala reviewed Sep 5, 2023

View reviewed changes

Comment thread api/src/main/java/org/apache/cloudstack/api/response/CapabilitiesResponse.java Outdated

harikrishna-patnala approved these changes Sep 5, 2023

View reviewed changes

jschoiRR added a commit to jschoiRR/ablestack-mold that referenced this pull request Sep 5, 2023

apache#7939 해당 내용 반영

9cdacb2

shwstppr approved these changes Sep 5, 2023

View reviewed changes

Pearl1594 approved these changes Sep 5, 2023

View reviewed changes

yadvr approved these changes Sep 5, 2023

View reviewed changes

Add since parameter

75f7d14

yadvr merged commit 940733c into apache:main Sep 11, 2023

yadvr deleted the fix-user-login-apicall branch September 11, 2023 08:38

Uh oh!

Conversation

nvazquez commented Sep 4, 2023

Description

Types of changes

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

Uh oh!

shwstppr left a comment

Choose a reason for hiding this comment

Uh oh!

nvazquez commented Sep 4, 2023

Uh oh!

shwstppr commented Sep 4, 2023

Uh oh!

nvazquez commented Sep 4, 2023

Uh oh!

nvazquez commented Sep 4, 2023

Uh oh!

blueorangutan commented Sep 4, 2023

Uh oh!

codecov Bot commented Sep 4, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

blueorangutan commented Sep 4, 2023

Uh oh!

nvazquez commented Sep 4, 2023

Uh oh!

blueorangutan commented Sep 4, 2023

Uh oh!

Uh oh!

blueorangutan commented Sep 5, 2023

Uh oh!

shwstppr left a comment

Choose a reason for hiding this comment

Uh oh!

yadvr left a comment

Choose a reason for hiding this comment

Uh oh!

nvazquez commented Sep 6, 2023

Uh oh!

blueorangutan commented Sep 6, 2023

Uh oh!

blueorangutan commented Sep 6, 2023

Uh oh!

nvazquez commented Sep 6, 2023

Uh oh!

blueorangutan commented Sep 6, 2023

Uh oh!

blueorangutan commented Sep 7, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

codecov Bot commented Sep 4, 2023 •

edited

Loading