Skip to content

Add Service Ip to listManagementServers API response - #7374

Merged
weizhouapache merged 1 commit into
apache:4.18from
shapeblue:CS-7338
Mar 29, 2023
Merged

Add Service Ip to listManagementServers API response#7374
weizhouapache merged 1 commit into
apache:4.18from
shapeblue:CS-7338

Conversation

@kishankavala

@kishankavala kishankavala commented Mar 28, 2023 •
edited by harikrishna-patnala
Loading

Copy link
Copy Markdown
Contributor

Description

This PR fixes # #7338
Added Mgmt server Service IP to listManagementServers API response

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

Test API response with cmk

(local) 🐱 > list managementservers
{
  "count": 1,
  "managementserver": [
    {
      "id": "76942b7f-00cc-4ff6-89ec-0d16bdcf2919",
      "javadistribution": "Ubuntu",
      "javaversion": "11.0.18+10-post-Ubuntu-0ubuntu122.04",
      "lastboottime": "2023-03-25T18:14:53+0530",
      "lastserverstart": "2023-03-28T14:10:19+0530",
      "lastserverstop": "2023-03-28T14:02:23+0530",
      "name": "KK.",
      "osdistribution": "Ubuntu 22.04.1 LTS",
      "serviceip": "127.0.0.1",
      "state": "Up",
      "version": "4.18.1.0-SNAPSHOT"
    }
  ]
}

weizhouapache
weizhouapache approved these changes Mar 28, 2023
View reviewed changes

@weizhouapache weizhouapache left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code lgtm

@weizhouapache

weizhouapache commented Mar 28, 2023

Copy link
Copy Markdown
Member

@blueorangutan package

@blueorangutan

blueorangutan commented Mar 28, 2023

Copy link
Copy Markdown

@weizhouapache a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@codecov

codecov Bot commented Mar 28, 2023

Copy link
Copy Markdown

Codecov Report

Merging #7374 (eda9625) into 4.18 (74a414e) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

@@             Coverage Diff              @@
##               4.18    #7374      +/-   ##
============================================
- Coverage     12.69%   12.68%   -0.01%     
+ Complexity     8657     8656       -1     
============================================
  Files          2717     2717              
  Lines        256143   256147       +4     
  Branches      39930    39924       -6     
============================================
- Hits          32506    32504       -2     
- Misses       219502   219509       +7     
+ Partials       4135     4134       -1
Impacted Files Coverage Δ
...ain/java/com/cloud/api/query/QueryManagerImpl.java 2.94% <0.00%> (-0.01%) ⬇️

... and 10 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@sonarqubecloud

sonarqubecloud Bot commented Mar 28, 2023

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@blueorangutan

blueorangutan commented Mar 28, 2023

Copy link
Copy Markdown

Packaging result: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 5791

harikrishna-patnala
harikrishna-patnala approved these changes Mar 28, 2023
View reviewed changes

@harikrishna-patnala harikrishna-patnala left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

verified it locally. LGTM

(localcloud) 🐱 > list managementservers
{
"count": 1,
"managementserver": [
{
"id": "b35efde0-355c-438d-a6ea-bcbd80c780be",
"javadistribution": "Red Hat, Inc.",
"javaversion": "11.0.18+10-LTS",
"lastboottime": "2023-03-23T16:05:25+0000",
"lastserverstart": "2023-03-28T10:57:44+0000",
"lastserverstop": "2023-03-27T10:49:57+0000",
"name": "ref-trl-4713-k-M7-harikrishna-patnala-mgmt1.shapeblue.com",
"osdistribution": "CentOS Linux 7 (Core)",
"serviceip": "10.0.x.y",
"state": "Up",
"version": "4.19.0.0-SNAPSHOT"
}
]
}

@yadvr

yadvr commented Mar 29, 2023

Copy link
Copy Markdown
Member

@blueorangutan test

@blueorangutan

blueorangutan commented Mar 29, 2023

Copy link
Copy Markdown

@rohityadavcloud a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

kiranchavala
kiranchavala approved these changes Mar 29, 2023
View reviewed changes

@kiranchavala kiranchavala left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested the build, The api call is working fine LGTM

(cmk) 🐱 > list managementservers
{
"count": 2,
"managementserver": [
{
"id": "c752ddd8-fa57-420f-9672-a5f54ba1003c",
"javadistribution": "Red Hat, Inc.",
"javaversion": "11.0.18+10-LTS",
"lastboottime": "2023-03-29T00:01:34+0000",
"lastserverstart": "2023-03-29T12:08:31+0000",
"lastserverstop": "2023-03-29T12:08:29+0000",
"name": "pr7374-t6333-kvm-centos7-mgmt1.sofia.shapeblue.com",
"osdistribution": "CentOS Linux 7 (Core)",
"serviceip": "10.0.33.218",
"state": "Up",
"version": "4.18.1.0-SNAPSHOT"
},
{
"id": "6ee9efd6-f57a-4252-8307-2fed851b8c92",
"javadistribution": "Red Hat, Inc.",
"javaversion": "11.0.18+10-LTS",
"lastboottime": "2023-03-29T00:02:00+0000",
"lastserverstart": "2023-03-29T12:08:31+0000",
"lastserverstop": "2023-03-29T12:08:29+0000",
"name": "pr7374-t6333-kvm-centos7-mgmt2.sofia.shapeblue.com",
"osdistribution": "CentOS Linux 7 (Core)",
"serviceip": "10.0.35.124",
"state": "Up",
"version": "4.18.1.0-SNAPSHOT"
}
]
}

@weizhouapache

weizhouapache commented Mar 29, 2023

Copy link
Copy Markdown
Member

merging based on 3 approvals and 2 manual testing

@weizhouapache
weizhouapache merged commit 17b8631 into apache:4.18 Mar 29, 2023
DaanHoogland added a commit that referenced this pull request Mar 29, 2023
@DaanHoogland
Merge release branch 4.18 to main
c2cffcc 
* 4.18:
  Fixed avoid set variables which is causing deployment failures (#7372)
  Add service ip to listManagementServers API response (#7374)
  UI: fix default network is not passed to deployvm API (#7367)
  ui: Added UEFI support flag in host details view (#7361)
  removed vulnerable workflow
@shwstppr shwstppr mentioned this pull request Apr 6, 2023
Closed
kishankavala added a commit to shapeblue/cloudstack that referenced this pull request Apr 13, 2023
@kishankavala
Add service ip to listManagementServers API response (apache#7374)
6ad381a
@weizhouapache weizhouapache added this to the 4.18.1.0 milestone May 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kiranchavala kiranchavala kiranchavala approved these changes
@harikrishna-patnala harikrishna-patnala harikrishna-patnala approved these changes
@weizhouapache weizhouapache weizhouapache approved these changes

Assignees

No one assigned

Labels

component:api

Projects

None yet

Milestone

4.18.1.0

Development

Successfully merging this pull request may close these issues.

6 participants

@kishankavala @weizhouapache @blueorangutan @yadvr @kiranchavala @harikrishna-patnala