Skip to content

Gateways after Nic update on Shared Network tests - #6355

Merged
nvazquez merged 2 commits into
apache:mainfrom
shapeblue:gatewaysOnSharedNetworkTests
May 5, 2022
Merged

Gateways after Nic update on Shared Network tests#6355
nvazquez merged 2 commits into
apache:mainfrom
shapeblue:gatewaysOnSharedNetworkTests

Conversation

@DaanHoogland

@DaanHoogland DaanHoogland commented May 4, 2022

Copy link
Copy Markdown
Contributor

Description

This PR add a test to verify that the right gateways and netmasks are set on updates of IPs from a different range on shared networks. This was fixed in #5105

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

integration test only

@DaanHoogland DaanHoogland added this to the 4.17.0.0 milestone May 4, 2022
@acs-robot

acs-robot commented May 4, 2022

Copy link
Copy Markdown

Found UI changes, kicking a new UI QA build
@blueorangutan ui

@blueorangutan

blueorangutan commented May 4, 2022

Copy link
Copy Markdown

@acs-robot a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@blueorangutan

blueorangutan commented May 4, 2022

Copy link
Copy Markdown

UI build: ✔️
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/6355 (SL-JID-1522)

@sonarqubecloud

sonarqubecloud Bot commented May 4, 2022

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@nvazquez

nvazquez commented May 5, 2022

Copy link
Copy Markdown
Contributor

@blueorangutan package

@blueorangutan

blueorangutan commented May 5, 2022

Copy link
Copy Markdown

@nvazquez a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan

blueorangutan commented May 5, 2022

Copy link
Copy Markdown

Packaging result: ✔️ el7 ✔️ el8 ✔️ debian ✔️ suse15. SL-JID 3351

weizhouapache
weizhouapache approved these changes May 5, 2022
View reviewed changes

@weizhouapache weizhouapache left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tests passed in my testing

@weizhouapache

weizhouapache commented May 5, 2022

Copy link
Copy Markdown
Member

@blueorangutan test

@blueorangutan

blueorangutan commented May 5, 2022

Copy link
Copy Markdown

@weizhouapache a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

@blueorangutan

blueorangutan commented May 5, 2022

Copy link
Copy Markdown

Trillian test result (tid-4124)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 40127 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6355-t4124-kvm-centos7.zip
Smoke tests completed. 95 look OK, 1 have errors
Only failed tests results shown below:

Test Result Time (s) Test File
test_05_create_template_with_no_checksum Error 65.48 test_templates.py

@nvazquez
nvazquez merged commit f572c7a into apache:main May 5, 2022
DaanHoogland added a commit to shapeblue/cloudstack that referenced this pull request May 20, 2022
@DaanHoogland
backport of apache#6355; test gateway and netmask after nic update in…
ce94773 
… shared nets
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nvazquez nvazquez nvazquez approved these changes
@weizhouapache weizhouapache weizhouapache approved these changes

Assignees

No one assigned

Labels

component:integration-test component:marvin Python Warning... Python code Ahead!

Projects

None yet

Milestone

4.17.0.0

Development

Successfully merging this pull request may close these issues.

5 participants

@DaanHoogland @acs-robot @blueorangutan @nvazquez @weizhouapache