plugin-storage-volume-linstor: Linstor SDS volume storage plugin

This commit adds a volume(primary) storage plugin for the Linstor SDS. Currently it can create/delete/migrate volumes, snapshots should be possible, but currently don't work for RAW volume types in cloudstack.
apache · yadvr · Sep 16, 2021 · Apr 13, 2021 · Apr 15, 2021 · Sep 6, 2021
commit d5ac92b14ade3e48e6f4d4d498a955f1ee25219d
diff --git a/api/src/main/java/com/cloud/storage/Storage.java b/api/src/main/java/com/cloud/storage/Storage.java
@@ -147,6 +147,7 @@ public static enum StoragePoolType {
         Gluster(true, false),
         PowerFlex(true, true), // Dell EMC PowerFlex/ScaleIO (formerly VxFlexOS)
         ManagedNFS(true, false),
+        Linstor(true, true),
         DatastoreCluster(true, true); // for VMware, to abstract pool of clusters
 
         private final boolean shared;

diff --git a/api/src/test/java/com/cloud/storage/StorageTest.java b/api/src/test/java/com/cloud/storage/StorageTest.java
@@ -48,6 +48,7 @@ public void isSharedStoragePool() {
         Assert.assertTrue(StoragePoolType.Gluster.isShared());
         Assert.assertTrue(StoragePoolType.ManagedNFS.isShared());
         Assert.assertTrue(StoragePoolType.DatastoreCluster.isShared());
+        Assert.assertTrue(StoragePoolType.Linstor.isShared());
     }
 
     @Test
@@ -71,5 +72,6 @@ public void supportsOverprovisioningStoragePool() {
         Assert.assertFalse(StoragePoolType.Gluster.supportsOverProvisioning());
         Assert.assertFalse(StoragePoolType.ManagedNFS.supportsOverProvisioning());
         Assert.assertTrue(StoragePoolType.DatastoreCluster.supportsOverProvisioning());
+        Assert.assertTrue(StoragePoolType.Linstor.supportsOverProvisioning());
     }
 }
diff --git a/client/pom.xml b/client/pom.xml
@@ -92,6 +92,11 @@
             <artifactId>cloud-plugin-storage-volume-scaleio</artifactId>
             <version>${project.version}</version>
         </dependency>
+        <dependency>
+            <groupId>org.apache.cloudstack</groupId>
+            <artifactId>cloud-plugin-storage-volume-linstor</artifactId>
+            <version>${project.version}</version>
+        </dependency>
         <dependency>
             <groupId>org.apache.cloudstack</groupId>
             <artifactId>cloud-server</artifactId>

diff --git a/engine/storage/integration-test/pom.xml b/engine/storage/integration-test/pom.xml
@@ -99,6 +99,12 @@
             <version>${project.version}</version>
             <scope>test</scope>
         </dependency>
+        <dependency>
+            <groupId>org.apache.cloudstack</groupId>
+            <artifactId>cloud-plugin-storage-volume-linstor</artifactId>
+            <version>${project.version}</version>
+            <scope>test</scope>
+        </dependency>
         <dependency>
             <groupId>org.apache.cloudstack</groupId>
             <artifactId>cloud-secondary-storage</artifactId>

diff --git a/plugins/hypervisors/kvm/pom.xml b/plugins/hypervisors/kvm/pom.xml
@@ -62,6 +62,11 @@
             <artifactId>rados</artifactId>
             <version>${cs.rados-java.version}</version>
         </dependency>
+        <dependency>
+            <groupId>com.linbit.linstor.api</groupId>
+            <artifactId>java-linstor</artifactId>
+            <version>${cs.java-linstor.version}</version>
+        </dependency>
         <dependency>
             <groupId>net.java.dev.jna</groupId>
             <artifactId>jna</artifactId>

diff --git a/...hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/storage/KVMStoragePoolManager.java b/...hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/storage/KVMStoragePoolManager.java
@@ -378,7 +378,7 @@ public KVMPhysicalDisk createDiskFromTemplate(KVMPhysicalDisk template, String n
             return adaptor.createDiskFromTemplate(template, name,
                     PhysicalDiskFormat.DIR, provisioningType,
                     size, destPool, timeout);
-        } else if (destPool.getType() == StoragePoolType.PowerFlex) {
+        } else if (destPool.getType() == StoragePoolType.PowerFlex || destPool.getType() == StoragePoolType.Linstor) {
             return adaptor.createDiskFromTemplate(template, name,
                     PhysicalDiskFormat.RAW, provisioningType,
                     size, destPool, timeout);

diff --git a/...s/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/storage/KVMStorageProcessor.java b/...s/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/storage/KVMStorageProcessor.java
@@ -282,7 +282,9 @@ public Answer copyTemplateToPrimaryStorage(final CopyCommand cmd) {
                 final TemplateObjectTO newTemplate = new TemplateObjectTO();
                 newTemplate.setPath(primaryVol.getName());
                 newTemplate.setSize(primaryVol.getSize());
-                if (primaryPool.getType() == StoragePoolType.RBD || primaryPool.getType() == StoragePoolType.PowerFlex) {
+                if (primaryPool.getType() == StoragePoolType.RBD ||
+                    primaryPool.getType() == StoragePoolType.PowerFlex ||
+                    primaryPool.getType() == StoragePoolType.Linstor) {
                     newTemplate.setFormat(ImageFormat.RAW);
                 } else {
                     newTemplate.setFormat(ImageFormat.QCOW2);