Systemvm template api by Spaceman1984 · Pull Request #3748 · apache/cloudstack

Spaceman1984 · 2019-12-07T06:54:02Z

Description

This feature adds an api to install a system vm template without the need to do an upgrade of cloudstack.

Wiki page can be found here:
https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=134745959

Types of changes

Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change which adds functionality)
Bug fix (non-breaking change which fixes an issue)
Enhancement (improves an existing feature and functionality)
Cleanup (Code refactoring and cleanup, that may add test cases)

Screenshots (if appropriate):

How Has This Been Tested?

This feature has been tested by executing the API with Cloudmonkey, Marvin and from the ui.
The integration tests can be found at /tests/integration/smoke/test_activate_template.py

DaanHoogland

loads of comments @Spaceman1984 , sure not all pertain to your code so let's go through them. not all of them very serious and some just questions.
All in all I think most of us are very happy with this change.

DaanHoogland

code lgtm, new functionality, should be quite useful.

borisstoyanov · 2019-12-19T12:22:07Z

@blueorangutan package

borisstoyanov · 2019-12-19T14:26:32Z

@blueorangutan test matrix

borisstoyanov · 2019-12-20T06:49:24Z

@Spaceman1984 can you resolve the conflicts please

borisstoyanov · 2019-12-20T08:00:46Z

@blueorangutan package

Spaceman1984 · 2020-01-13T10:54:45Z

@blueorangutan package

Spaceman1984 · 2020-01-13T14:46:14Z

@blueorangutan package

Spaceman1984 · 2020-01-14T08:45:36Z

@blueorangutan package

Spaceman1984 · 2020-01-16T10:14:56Z

@blueorangutan package

weizhouapache · 2020-01-16T10:32:01Z

@Spaceman1984
this implementation looks complicated.
IMHO, if cloudstack allows admin to change a template from USER to SYSTEM, it is good enough for me.

steps
(1) register template or upload template from local
(2) change template type from USER to SYSTEM
(3) change global settings to use the new template per hypervisor.

Spaceman1984 · 2020-01-17T06:58:04Z

@blueorangutan package

Spaceman1984 · 2020-01-17T07:19:20Z

@Spaceman1984
this implementation looks complicated.
IMHO, if cloudstack allows admin to change a template from USER to SYSTEM, it is good enough for me.

steps
(1) register template or upload template from local
(2) change template type from USER to SYSTEM
(3) change global settings to use the new template per hypervisor.

Hi @weizhouapache

This implementation may seem complicated because it adds a few more features. It will allow the following:

Remove the need to upload a template as a user and then change a global setting.
Allow a system VM template to be installed without any secondary storage virtual machine running.
Remove the necessity for an admin to manually run a shell script to install the system VM template on a fresh installation of Cloudstack.
Add options on the zone creation wizard to copy the system VM template from an existing zone, upload a system VM template from local, download and install the official Cloudstack system VM template or through specifying a URL.

Spaceman1984 · 2020-01-17T08:45:35Z

@blueorangutan package

borisstoyanov · 2020-01-22T08:35:20Z

@blueorangutan package

borisstoyanov · 2020-01-22T14:15:59Z

@blueorangutan package

borisstoyanov · 2020-01-23T07:57:36Z

@blueorangutan test

…es not being removed when adding system templates from the wizzard.

…flag to zone multi select box

Spaceman1984 · 2020-02-03T08:05:54Z

@blueorangutan package

blueorangutan · 2020-02-03T08:06:42Z

@Spaceman1984 a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

blueorangutan · 2020-02-03T08:25:11Z

Packaging result: ✖centos6 ✔centos7 ✔debian. JID-735

blueorangutan · 2020-02-03T08:52:40Z

Packaging result: ✖centos6 ✔centos7 ✔debian. JID-737

blueorangutan · 2020-02-03T16:04:12Z

Trillian test result (tid-878)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 22582 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3748-t878-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_affinity_groups_projects.py
Intermittent failure detected: /marvin/tests/smoke/test_affinity_groups.py
Intermittent failure detected: /marvin/tests/smoke/test_async_job.py
Intermittent failure detected: /marvin/tests/smoke/test_deploy_virtio_scsi_vm.py
Intermittent failure detected: /marvin/tests/smoke/test_deploy_vm_extra_config_data.py
Intermittent failure detected: /marvin/tests/smoke/test_deploy_vm_iso.py
Intermittent failure detected: /marvin/tests/smoke/test_deploy_vm_root_resize.py
Intermittent failure detected: /marvin/tests/smoke/test_deploy_vms_with_varied_deploymentplanners.py
Intermittent failure detected: /marvin/tests/smoke/test_deploy_vm_with_userdata.py
Intermittent failure detected: /marvin/tests/smoke/test_diagnostics.py
Intermittent failure detected: /marvin/tests/smoke/test_domain_service_offerings.py
Intermittent failure detected: /marvin/tests/smoke/test_internal_lb.py
Intermittent failure detected: /marvin/tests/smoke/test_list_ids_parameter.py
Intermittent failure detected: /marvin/tests/smoke/test_loadbalance.py
Intermittent failure detected: /marvin/tests/smoke/test_metrics_api.py
Intermittent failure detected: /marvin/tests/smoke/test_migration.py
Intermittent failure detected: /marvin/tests/smoke/test_multipleips_per_nic.py
Intermittent failure detected: /marvin/tests/smoke/test_network_acl.py
Intermittent failure detected: /marvin/tests/smoke/test_network.py
Intermittent failure detected: /marvin/tests/smoke/test_nic.py
Intermittent failure detected: /marvin/tests/smoke/test_password_server.py
Intermittent failure detected: /marvin/tests/smoke/test_portforwardingrules.py
Intermittent failure detected: /marvin/tests/smoke/test_primary_storage.py
Intermittent failure detected: /marvin/tests/smoke/test_privategw_acl.py
Intermittent failure detected: /marvin/tests/smoke/test_projects.py
Intermittent failure detected: /marvin/tests/smoke/test_reset_vm_on_reboot.py
Intermittent failure detected: /marvin/tests/smoke/test_resource_accounting.py
Intermittent failure detected: /marvin/tests/smoke/test_router_dhcphosts.py
Intermittent failure detected: /marvin/tests/smoke/test_router_dns.py
Intermittent failure detected: /marvin/tests/smoke/test_router_dnsservice.py
Intermittent failure detected: /marvin/tests/smoke/test_routers_iptables_default_policy.py
Intermittent failure detected: /marvin/tests/smoke/test_routers_network_ops.py
Intermittent failure detected: /marvin/tests/smoke/test_routers.py
Intermittent failure detected: /marvin/tests/smoke/test_service_offerings.py
Intermittent failure detected: /marvin/tests/smoke/test_snapshots.py
Intermittent failure detected: /marvin/tests/smoke/test_templates.py
Intermittent failure detected: /marvin/tests/smoke/test_usage.py
Intermittent failure detected: /marvin/tests/smoke/test_vm_deployment_planner.py
Intermittent failure detected: /marvin/tests/smoke/test_vm_life_cycle.py
Intermittent failure detected: /marvin/tests/smoke/test_vm_snapshots.py
Intermittent failure detected: /marvin/tests/smoke/test_volumes.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_router_nics.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_vpn.py
Intermittent failure detected: /marvin/tests/smoke/test_host_maintenance.py
Smoke tests completed. 36 look OK, 44 have error(s)
Only failed tests results shown below:

Test	Result	Time (s)	Test File
test_DeployVmAntiAffinityGroup_in_project	`Error`	72.32	test_affinity_groups_projects.py
test_DeployVmAffinityGroup	`Error`	66.08	test_affinity_groups.py
test_DeployVmAntiAffinityGroup	`Error`	69.08	test_affinity_groups.py
test_query_async_job_result	`Error`	64.72	test_async_job.py
ContextSuite context=TestDeployVirtioSCSIVM>:setup	`Error`	0.00	test_deploy_virtio_scsi_vm.py
test_02_deploy_vm_with_extraconfig_kvm	`Error`	64.14	test_deploy_vm_extra_config_data.py
test_03_update_vm_with_extraconfig_kvm	`Error`	63.04	test_deploy_vm_extra_config_data.py
test_deploy_vm_from_iso	`Error`	70.91	test_deploy_vm_iso.py
test_01_internallb_roundrobin_1VPC_3VM_HTTP_port80	`Error`	38.14	test_internal_lb.py
test_01_internallb_roundrobin_1VPC_3VM_HTTP_port80	`Error`	40.33	test_internal_lb.py
test_02_internallb_roundrobin_1RVPC_3VM_HTTP_port80	`Error`	71.99	test_internal_lb.py
test_02_internallb_roundrobin_1RVPC_3VM_HTTP_port80	`Error`	74.20	test_internal_lb.py
test_03_vpc_internallb_haproxy_stats_on_all_interfaces	`Error`	37.87	test_internal_lb.py
test_03_vpc_internallb_haproxy_stats_on_all_interfaces	`Error`	38.97	test_internal_lb.py
test_04_rvpc_internallb_haproxy_stats_on_all_interfaces	`Error`	76.97	test_internal_lb.py
test_04_rvpc_internallb_haproxy_stats_on_all_interfaces	`Error`	78.06	test_internal_lb.py
test_00_deploy_vm_root_resize	`Error`	60.97	test_deploy_vm_root_resize.py
test_deployvm_firstfit	`Error`	63.95	test_deploy_vms_with_varied_deploymentplanners.py
test_deployvm_userconcentrated	`Error`	63.88	test_deploy_vms_with_varied_deploymentplanners.py
test_deployvm_userdispersing	`Error`	60.83	test_deploy_vms_with_varied_deploymentplanners.py
test_deployvm_userdata	`Error`	64.19	test_deploy_vm_with_userdata.py
test_deployvm_userdata_post	`Error`	63.98	test_deploy_vm_with_userdata.py
ContextSuite context=TestRemoteDiagnostics>:setup	`Error`	0.00	test_diagnostics.py
ContextSuite context=TestLoadBalance>:setup	`Error`	0.00	test_loadbalance.py
test_03_deploy_vm_domain_service_offering	`Error`	66.43	test_domain_service_offerings.py
ContextSuite context=TestListIdsParams>:setup	`Error`	0.00	test_list_ids_parameter.py
test_list_vms_metrics	`Error`	72.38	test_metrics_api.py
test_01_native_to_native_network_migration	`Error`	75.22	test_migration.py
test_02_native_to_native_vpc_migration	`Error`	37.16	test_migration.py
test_nic_secondaryip_add_remove	`Error`	84.00	test_multipleips_per_nic.py
test_network_acl	`Error`	38.69	test_network_acl.py
test_delete_account	`Error`	91.32	test_network.py
ContextSuite context=TestPortForwarding>:setup	`Error`	120.70	test_network.py
ContextSuite context=TestPublicIP>:setup	`Error`	193.64	test_network.py
test_reboot_router	`Error`	76.07	test_network.py
test_releaseIP	`Error`	79.45	test_network.py
ContextSuite context=TestRouterRules>:setup	`Error`	158.62	test_network.py
test_01_nic	`Error`	70.31	test_nic.py
ContextSuite context=TestIsolatedNetworksPasswdServer>:setup	`Error`	0.00	test_password_server.py
test_01_create_delete_portforwarding_fornonvpc	`Error`	71.42	test_portforwardingrules.py
test_01_add_primary_storage_disabled_host	`Error`	37.37	test_primary_storage.py
test_01_primary_storage_nfs	`Error`	0.15	test_primary_storage.py
ContextSuite context=TestStorageTags>:setup	`Error`	0.26	test_primary_storage.py
test_01_vpc_privategw_acl	`Failure`	2.99	test_privategw_acl.py
test_02_vpc_privategw_static_routes	`Failure`	2.97	test_privategw_acl.py
test_03_vpc_privategw_restart_vpc_cleanup	`Failure`	2.97	test_privategw_acl.py
test_04_rvpc_privategw_static_routes	`Failure`	3.02	test_privategw_acl.py
test_09_project_suspend	`Error`	4.54	test_projects.py
test_10_project_activation	`Error`	4.38	test_projects.py
ContextSuite context=TestResetVmOnReboot>:setup	`Error`	0.00	test_reset_vm_on_reboot.py
test_01_so_removal_resource_update	`Error`	4.52	test_resource_accounting.py
ContextSuite context=TestRouterServices>:setup	`Error`	0.00	test_routers.py
ContextSuite context=TestRouterDHCPHosts>:setup	`Error`	0.00	test_router_dhcphosts.py
ContextSuite context=TestRouterDHCPOpts>:setup	`Error`	0.00	test_router_dhcphosts.py
ContextSuite context=TestRouterDns>:setup	`Error`	0.00	test_router_dns.py
ContextSuite context=TestRouterDnsService>:setup	`Error`	0.00	test_router_dnsservice.py
test_02_routervm_iptables_policies	`Error`	5.49	test_routers_iptables_default_policy.py
test_01_single_VPC_iptables_policies	`Error`	2.32	test_routers_iptables_default_policy.py
test_01_isolate_network_FW_PF_default_routes_egress_true	`Error`	4.60	test_routers_network_ops.py
test_02_isolate_network_FW_PF_default_routes_egress_false	`Error`	5.61	test_routers_network_ops.py
test_01_RVR_Network_FW_PF_SSH_default_routes_egress_true	`Error`	0.39	test_routers_network_ops.py
test_02_RVR_Network_FW_PF_SSH_default_routes_egress_false	`Error`	0.35	test_routers_network_ops.py
test_03_RVR_Network_check_router_state	`Error`	0.34	test_routers_network_ops.py
ContextSuite context=TestCpuCapServiceOfferings>:setup	`Error`	0.00	test_service_offerings.py
ContextSuite context=TestServiceOfferings>:setup	`Error`	5.39	test_service_offerings.py
ContextSuite context=TestSnapshotRootDisk>:setup	`Error`	0.00	test_snapshots.py
test_02_deploy_vm_from_direct_download_template	`Error`	3.40	test_templates.py
test_03_deploy_vm_wrong_checksum	`Error`	4.45	test_templates.py
ContextSuite context=TestTemplates>:setup	`Error`	24.95	test_templates.py
ContextSuite context=TestLBRuleUsage>:setup	`Error`	8.45	test_usage.py
ContextSuite context=TestNatRuleUsage>:setup	`Error`	14.66	test_usage.py
ContextSuite context=TestPublicIPUsage>:setup	`Error`	20.86	test_usage.py
ContextSuite context=TestSnapshotUsage>:setup	`Error`	26.05	test_usage.py
ContextSuite context=TestVmUsage>:setup	`Error`	43.98	test_usage.py
ContextSuite context=TestVolumeUsage>:setup	`Error`	48.20	test_usage.py
ContextSuite context=TestVpnUsage>:setup	`Error`	54.45	test_usage.py
test_01_deploy_vm_on_specific_host	`Error`	2.39	test_vm_deployment_planner.py
test_02_deploy_vm_on_specific_cluster	`Error`	2.28	test_vm_deployment_planner.py
test_03_deploy_vm_on_specific_pod	`Error`	1.29	test_vm_deployment_planner.py
test_04_deploy_vm_on_host_override_pod_and_cluster	`Error`	2.35	test_vm_deployment_planner.py
test_05_deploy_vm_on_cluster_override_pod	`Error`	2.29	test_vm_deployment_planner.py
ContextSuite context=Test01DeployVM>:setup	`Error`	0.00	test_vm_life_cycle.py
ContextSuite context=Test02VMLifeCycle>:setup	`Error`	0.00	test_vm_life_cycle.py
test_14_secure_to_secure_vm_migration	`Error`	12.49	test_vm_life_cycle.py
test_15_secured_to_nonsecured_vm_migration	`Error`	75.63	test_vm_life_cycle.py
test_16_nonsecured_to_secured_vm_migration	`Error`	2.32	test_vm_life_cycle.py
ContextSuite context=TestVmSnapshot>:setup	`Error`	5.18	test_vm_snapshots.py
ContextSuite context=TestCreateVolume>:setup	`Error`	0.00	test_volumes.py
ContextSuite context=TestVolumes>:setup	`Error`	0.00	test_volumes.py
test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL	`Error`	3.06	test_vpc_redundant.py
test_02_redundant_VPC_default_routes	`Error`	3.02	test_vpc_redundant.py
test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers	`Error`	3.02	test_vpc_redundant.py
test_04_rvpc_network_garbage_collector_nics	`Error`	3.06	test_vpc_redundant.py
test_05_rvpc_multi_tiers	`Error`	3.03	test_vpc_redundant.py
test_01_VPC_nics_after_destroy	`Error`	3.01	test_vpc_router_nics.py
test_02_VPC_default_routes	`Error`	3.00	test_vpc_router_nics.py
test_01_redundant_vpc_site2site_vpn	`Failure`	2.42	test_vpc_vpn.py
test_01_vpc_site2site_vpn_multiple_options	`Failure`	2.37	test_vpc_vpn.py
test_01_vpc_remote_access_vpn	`Failure`	1.24	test_vpc_vpn.py
test_01_vpc_site2site_vpn	`Failure`	2.40	test_vpc_vpn.py

yadvr · 2020-02-04T10:31:52Z

Looks like an env issue, I would alway try to rekick the job to see if I'm able to consistently reproduce the issue @Spaceman1984

@blueorangutan test

blueorangutan · 2020-02-04T10:32:47Z

@rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

(maybe non related) issues arose, we need to reconsidder this

blueorangutan · 2020-02-04T16:23:26Z

Trillian test result (tid-882)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 19432 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3748-t882-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_affinity_groups_projects.py
Intermittent failure detected: /marvin/tests/smoke/test_affinity_groups.py
Intermittent failure detected: /marvin/tests/smoke/test_async_job.py
Intermittent failure detected: /marvin/tests/smoke/test_deploy_virtio_scsi_vm.py
Intermittent failure detected: /marvin/tests/smoke/test_deploy_vm_extra_config_data.py
Intermittent failure detected: /marvin/tests/smoke/test_deploy_vm_iso.py
Intermittent failure detected: /marvin/tests/smoke/test_deploy_vm_root_resize.py
Intermittent failure detected: /marvin/tests/smoke/test_deploy_vms_with_varied_deploymentplanners.py
Intermittent failure detected: /marvin/tests/smoke/test_deploy_vm_with_userdata.py
Intermittent failure detected: /marvin/tests/smoke/test_diagnostics.py
Intermittent failure detected: /marvin/tests/smoke/test_domain_service_offerings.py
Intermittent failure detected: /marvin/tests/smoke/test_internal_lb.py
Intermittent failure detected: /marvin/tests/smoke/test_list_ids_parameter.py
Intermittent failure detected: /marvin/tests/smoke/test_loadbalance.py
Intermittent failure detected: /marvin/tests/smoke/test_metrics_api.py
Intermittent failure detected: /marvin/tests/smoke/test_migration.py
Intermittent failure detected: /marvin/tests/smoke/test_multipleips_per_nic.py
Intermittent failure detected: /marvin/tests/smoke/test_network_acl.py
Intermittent failure detected: /marvin/tests/smoke/test_network.py
Intermittent failure detected: /marvin/tests/smoke/test_nic.py
Intermittent failure detected: /marvin/tests/smoke/test_password_server.py
Intermittent failure detected: /marvin/tests/smoke/test_portforwardingrules.py
Intermittent failure detected: /marvin/tests/smoke/test_primary_storage.py
Intermittent failure detected: /marvin/tests/smoke/test_privategw_acl.py
Intermittent failure detected: /marvin/tests/smoke/test_projects.py
Intermittent failure detected: /marvin/tests/smoke/test_reset_vm_on_reboot.py
Intermittent failure detected: /marvin/tests/smoke/test_resource_accounting.py
Intermittent failure detected: /marvin/tests/smoke/test_router_dhcphosts.py
Intermittent failure detected: /marvin/tests/smoke/test_router_dns.py
Intermittent failure detected: /marvin/tests/smoke/test_router_dnsservice.py
Intermittent failure detected: /marvin/tests/smoke/test_routers_iptables_default_policy.py
Intermittent failure detected: /marvin/tests/smoke/test_routers_network_ops.py
Intermittent failure detected: /marvin/tests/smoke/test_routers.py
Intermittent failure detected: /marvin/tests/smoke/test_service_offerings.py
Intermittent failure detected: /marvin/tests/smoke/test_snapshots.py
Intermittent failure detected: /marvin/tests/smoke/test_templates.py
Intermittent failure detected: /marvin/tests/smoke/test_usage.py
Intermittent failure detected: /marvin/tests/smoke/test_vm_deployment_planner.py
Intermittent failure detected: /marvin/tests/smoke/test_vm_life_cycle.py
Intermittent failure detected: /marvin/tests/smoke/test_vm_snapshots.py
Intermittent failure detected: /marvin/tests/smoke/test_volumes.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_router_nics.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_vpn.py
Intermittent failure detected: /marvin/tests/smoke/test_host_maintenance.py
Smoke tests completed. 36 look OK, 44 have error(s)
Only failed tests results shown below:

Test	Result	Time (s)	Test File
test_DeployVmAntiAffinityGroup_in_project	`Error`	47.11	test_affinity_groups_projects.py
test_DeployVmAffinityGroup	`Error`	43.17	test_affinity_groups.py
test_DeployVmAntiAffinityGroup	`Error`	45.00	test_affinity_groups.py
test_query_async_job_result	`Error`	40.41	test_async_job.py
ContextSuite context=TestDeployVirtioSCSIVM>:setup	`Error`	0.00	test_deploy_virtio_scsi_vm.py
test_02_deploy_vm_with_extraconfig_kvm	`Error`	41.12	test_deploy_vm_extra_config_data.py
test_03_update_vm_with_extraconfig_kvm	`Error`	40.90	test_deploy_vm_extra_config_data.py
test_deploy_vm_from_iso	`Error`	45.52	test_deploy_vm_iso.py
test_01_internallb_roundrobin_1VPC_3VM_HTTP_port80	`Error`	22.20	test_internal_lb.py
test_01_internallb_roundrobin_1VPC_3VM_HTTP_port80	`Error`	24.35	test_internal_lb.py
test_02_internallb_roundrobin_1RVPC_3VM_HTTP_port80	`Error`	48.63	test_internal_lb.py
test_02_internallb_roundrobin_1RVPC_3VM_HTTP_port80	`Error`	50.77	test_internal_lb.py
test_03_vpc_internallb_haproxy_stats_on_all_interfaces	`Error`	24.05	test_internal_lb.py
test_03_vpc_internallb_haproxy_stats_on_all_interfaces	`Error`	25.12	test_internal_lb.py
test_04_rvpc_internallb_haproxy_stats_on_all_interfaces	`Error`	44.40	test_internal_lb.py
test_04_rvpc_internallb_haproxy_stats_on_all_interfaces	`Error`	45.47	test_internal_lb.py
test_00_deploy_vm_root_resize	`Error`	42.02	test_deploy_vm_root_resize.py
test_deployvm_firstfit	`Error`	40.03	test_deploy_vms_with_varied_deploymentplanners.py
test_deployvm_userconcentrated	`Error`	40.05	test_deploy_vms_with_varied_deploymentplanners.py
test_deployvm_userdispersing	`Error`	39.92	test_deploy_vms_with_varied_deploymentplanners.py
test_deployvm_userdata	`Error`	41.09	test_deploy_vm_with_userdata.py
test_deployvm_userdata_post	`Error`	40.03	test_deploy_vm_with_userdata.py
ContextSuite context=TestRemoteDiagnostics>:setup	`Error`	0.00	test_diagnostics.py
ContextSuite context=TestLoadBalance>:setup	`Error`	0.00	test_loadbalance.py
test_03_deploy_vm_domain_service_offering	`Error`	43.85	test_domain_service_offerings.py
ContextSuite context=TestListIdsParams>:setup	`Error`	0.00	test_list_ids_parameter.py
test_list_vms_metrics	`Error`	51.36	test_metrics_api.py
test_01_native_to_native_network_migration	`Error`	51.20	test_migration.py
test_02_native_to_native_vpc_migration	`Error`	29.56	test_migration.py
test_nic_secondaryip_add_remove	`Error`	70.09	test_multipleips_per_nic.py
test_network_acl	`Error`	32.22	test_network_acl.py
test_delete_account	`Error`	67.93	test_network.py
ContextSuite context=TestPortForwarding>:setup	`Error`	93.91	test_network.py
ContextSuite context=TestPublicIP>:setup	`Error`	143.28	test_network.py
test_reboot_router	`Error`	52.87	test_network.py
test_releaseIP	`Error`	52.77	test_network.py
ContextSuite context=TestRouterRules>:setup	`Error`	106.70	test_network.py
test_01_nic	`Error`	51.00	test_nic.py
ContextSuite context=TestIsolatedNetworksPasswdServer>:setup	`Error`	0.00	test_password_server.py
test_01_create_delete_portforwarding_fornonvpc	`Error`	60.25	test_portforwardingrules.py
test_01_add_primary_storage_disabled_host	`Error`	37.83	test_primary_storage.py
test_01_primary_storage_nfs	`Error`	0.09	test_primary_storage.py
ContextSuite context=TestStorageTags>:setup	`Error`	0.17	test_primary_storage.py
test_01_vpc_privategw_acl	`Failure`	2.65	test_privategw_acl.py
test_02_vpc_privategw_static_routes	`Failure`	1.70	test_privategw_acl.py
test_03_vpc_privategw_restart_vpc_cleanup	`Failure`	2.65	test_privategw_acl.py
test_04_rvpc_privategw_static_routes	`Failure`	2.69	test_privategw_acl.py
test_09_project_suspend	`Error`	4.34	test_projects.py
test_10_project_activation	`Error`	4.25	test_projects.py
ContextSuite context=TestResetVmOnReboot>:setup	`Error`	0.00	test_reset_vm_on_reboot.py
test_01_so_removal_resource_update	`Error`	5.37	test_resource_accounting.py
ContextSuite context=TestRouterServices>:setup	`Error`	0.00	test_routers.py
ContextSuite context=TestRouterDHCPHosts>:setup	`Error`	0.00	test_router_dhcphosts.py
ContextSuite context=TestRouterDHCPOpts>:setup	`Error`	0.00	test_router_dhcphosts.py
ContextSuite context=TestRouterDns>:setup	`Error`	0.00	test_router_dns.py
ContextSuite context=TestRouterDnsService>:setup	`Error`	0.00	test_router_dnsservice.py
test_02_routervm_iptables_policies	`Error`	4.33	test_routers_iptables_default_policy.py
test_01_single_VPC_iptables_policies	`Error`	2.22	test_routers_iptables_default_policy.py
test_01_isolate_network_FW_PF_default_routes_egress_true	`Error`	5.41	test_routers_network_ops.py
test_02_isolate_network_FW_PF_default_routes_egress_false	`Error`	3.37	test_routers_network_ops.py
test_01_RVR_Network_FW_PF_SSH_default_routes_egress_true	`Error`	0.24	test_routers_network_ops.py
test_02_RVR_Network_FW_PF_SSH_default_routes_egress_false	`Error`	0.23	test_routers_network_ops.py
test_03_RVR_Network_check_router_state	`Error`	0.23	test_routers_network_ops.py
ContextSuite context=TestCpuCapServiceOfferings>:setup	`Error`	0.00	test_service_offerings.py
ContextSuite context=TestServiceOfferings>:setup	`Error`	4.95	test_service_offerings.py
ContextSuite context=TestSnapshotRootDisk>:setup	`Error`	0.00	test_snapshots.py
test_02_deploy_vm_from_direct_download_template	`Error`	5.28	test_templates.py
test_03_deploy_vm_wrong_checksum	`Error`	3.31	test_templates.py
ContextSuite context=TestTemplates>:setup	`Error`	23.94	test_templates.py
ContextSuite context=TestLBRuleUsage>:setup	`Error`	6.91	test_usage.py
ContextSuite context=TestNatRuleUsage>:setup	`Error`	11.69	test_usage.py
ContextSuite context=TestPublicIPUsage>:setup	`Error`	15.44	test_usage.py
ContextSuite context=TestSnapshotUsage>:setup	`Error`	19.17	test_usage.py
ContextSuite context=TestVmUsage>:setup	`Error`	32.90	test_usage.py
ContextSuite context=TestVolumeUsage>:setup	`Error`	37.68	test_usage.py
ContextSuite context=TestVpnUsage>:setup	`Error`	41.44	test_usage.py
test_01_deploy_vm_on_specific_host	`Error`	2.24	test_vm_deployment_planner.py
test_02_deploy_vm_on_specific_cluster	`Error`	2.18	test_vm_deployment_planner.py
test_03_deploy_vm_on_specific_pod	`Error`	2.21	test_vm_deployment_planner.py
test_04_deploy_vm_on_host_override_pod_and_cluster	`Error`	2.21	test_vm_deployment_planner.py
test_05_deploy_vm_on_cluster_override_pod	`Error`	2.19	test_vm_deployment_planner.py
ContextSuite context=Test01DeployVM>:setup	`Error`	0.00	test_vm_life_cycle.py
ContextSuite context=Test02VMLifeCycle>:setup	`Error`	0.00	test_vm_life_cycle.py
test_14_secure_to_secure_vm_migration	`Error`	11.30	test_vm_life_cycle.py
test_15_secured_to_nonsecured_vm_migration	`Error`	74.05	test_vm_life_cycle.py
test_16_nonsecured_to_secured_vm_migration	`Error`	2.22	test_vm_life_cycle.py
ContextSuite context=TestVmSnapshot>:setup	`Error`	4.77	test_vm_snapshots.py
ContextSuite context=TestCreateVolume>:setup	`Error`	0.00	test_volumes.py
ContextSuite context=TestVolumes>:setup	`Error`	0.00	test_volumes.py
test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL	`Error`	2.67	test_vpc_redundant.py
test_02_redundant_VPC_default_routes	`Error`	3.72	test_vpc_redundant.py
test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers	`Error`	2.68	test_vpc_redundant.py
test_04_rvpc_network_garbage_collector_nics	`Error`	2.66	test_vpc_redundant.py
test_05_rvpc_multi_tiers	`Error`	2.66	test_vpc_redundant.py
test_01_VPC_nics_after_destroy	`Error`	2.91	test_vpc_router_nics.py
test_02_VPC_default_routes	`Error`	2.65	test_vpc_router_nics.py
test_01_redundant_vpc_site2site_vpn	`Failure`	2.27	test_vpc_vpn.py
test_01_vpc_site2site_vpn_multiple_options	`Failure`	2.23	test_vpc_vpn.py
test_01_vpc_remote_access_vpn	`Failure`	1.13	test_vpc_vpn.py
test_01_vpc_site2site_vpn	`Failure`	2.24	test_vpc_vpn.py

yadvr · 2021-06-17T07:16:51Z

Closing this, internally the project was abandoned. We're considering a new approach that we'll publish on dev ML soon led by @weizhouapache

Spaceman1984 changed the title ~~Systemvm template api~~ Systemvm template api (WIP) Dec 7, 2019

yadvr added this to the 4.14.0.0 milestone Dec 7, 2019

svenvogel added component:systemvm-template type:new-feature component:virtual-router labels Dec 8, 2019

DaanHoogland reviewed Dec 9, 2019

View reviewed changes

DaanHoogland requested changes Dec 12, 2019

View reviewed changes

DaanHoogland previously approved these changes Dec 17, 2019

View reviewed changes

andrijapanicsb changed the title ~~Systemvm template api (WIP)~~ [WIP DO NOT MERGE] Systemvm template api Jan 9, 2020

Spaceman1984 force-pushed the systemvm-template-api branch from 27d6228 to d22b85a Compare January 13, 2020 10:25

Spaceman1984 force-pushed the systemvm-template-api branch from a1b2bf8 to dd2dd59 Compare January 17, 2020 06:53

DaanHoogland closed this Jan 23, 2020

DaanHoogland reopened this Jan 23, 2020

apache deleted a comment from blueorangutan Jan 28, 2020

Spaceman1984 added 9 commits January 31, 2020 16:05

Fixed null pointer on uploading iso from local and old system templat…

051f5e4

…es not being removed when adding system templates from the wizzard.

Fixed activate template behaviour, improved error handling on wizzard

7af02f1

Added deprecated script warning

1773688

Fixed duplicate bean definition

1066601

Fixed file upload error when using advanced zone

b423f33

Fixed activate template visible for user template and added required …

909d04f

…flag to zone multi select box

Renamed id to zoneid on seed template api

cea0ec2

fixed failing delete_template test

5df90fe

Post rebase fix

d8532b9

Spaceman1984 force-pushed the systemvm-template-api branch from 02b9c24 to d8532b9 Compare February 3, 2020 08:05

apache deleted a comment from blueorangutan Feb 3, 2020

Merge remote-tracking branch 'origin/master' into systemvm-template-api

c8c1130

DaanHoogland requested a review from borisstoyanov February 4, 2020 12:45

yadvr modified the milestones: 4.14.0.0, 4.15.0.0 Feb 6, 2020

yadvr added the status:On Hold label Mar 8, 2020

yadvr changed the title ~~Systemvm template api~~ [WIP] Systemvm template api Mar 8, 2020

Uh oh!

Conversation

Spaceman1984 commented Dec 7, 2019

Description

Types of changes

Screenshots (if appropriate):

How Has This Been Tested?

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

DaanHoogland left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

DaanHoogland left a comment

Choose a reason for hiding this comment

Uh oh!

borisstoyanov commented Dec 19, 2019

Uh oh!

borisstoyanov commented Dec 19, 2019

Uh oh!

borisstoyanov commented Dec 20, 2019

Uh oh!

borisstoyanov commented Dec 20, 2019

Uh oh!

Spaceman1984 commented Jan 13, 2020

Uh oh!

Spaceman1984 commented Jan 13, 2020

Uh oh!

Spaceman1984 commented Jan 14, 2020

Uh oh!

Spaceman1984 commented Jan 16, 2020

Uh oh!

weizhouapache commented Jan 16, 2020

Uh oh!

Spaceman1984 commented Jan 17, 2020

Uh oh!

Spaceman1984 commented Jan 17, 2020

Uh oh!

Spaceman1984 commented Jan 17, 2020

Uh oh!

borisstoyanov commented Jan 22, 2020

Uh oh!

borisstoyanov commented Jan 22, 2020

Uh oh!

borisstoyanov commented Jan 23, 2020

Uh oh!

Spaceman1984 commented Feb 3, 2020

Uh oh!

blueorangutan commented Feb 3, 2020

Uh oh!

blueorangutan commented Feb 3, 2020

Uh oh!

blueorangutan commented Feb 3, 2020

Uh oh!

blueorangutan commented Feb 3, 2020

Uh oh!

yadvr commented Feb 4, 2020

Uh oh!

blueorangutan commented Feb 4, 2020

Uh oh!

blueorangutan commented Feb 4, 2020

Uh oh!

yadvr commented Jun 17, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects