Skip to content

Linstor: fix create volume from snapshot on primary storage #13043

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Kukunin wants to merge 3 commits into
base: main
Choose a base branch
from
+137 −2
Open

Linstor: fix create volume from snapshot on primary storage #13043

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f89df71
Linstor: fix create volume from snapshot on primary storage
Kukunin Apr 18, 2026
c70dee1
Let CloudRuntimeException propagate from copySnapshotToVolume
Kukunin Apr 21, 2026
44e98fe
Fix CAN_CREATE_TEMPLATE_FROM_SNAPSHOT breaking template creation
Kukunin Apr 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Let CloudRuntimeException propagate from copySnapshotToVolume 
Remove try/catch in copySnapshotToVolume so that CloudRuntimeException
from createResourceFromSnapshot propagates to the caller, ensuring
CloudStack properly notices and reports the failure.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
  • Loading branch information
@Kukunin @claude
Kukunin and claude committed Apr 21, 2026
commit c70dee1ff552e183c49f9134273f5dfd88589236
27 changes: 9 additions & 18 deletions ...ava/org/apache/cloudstack/storage/datastore/driver/LinstorPrimaryDataStoreDriverImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -778,24 +778,15 @@ public boolean canCopy(DataObject srcData, DataObject dstData)
}

private CopyCommandResult copySnapshotToVolume(SnapshotInfo snapshotInfo, VolumeInfo volumeInfo) {
String errMsg = null;
CopyCmdAnswer answer = null;
try {
StoragePoolVO storagePoolVO = _storagePoolDao.findById(snapshotInfo.getDataStore().getId());
String rscName = LinstorUtil.RSC_PREFIX + volumeInfo.getUuid();
createResourceFromSnapshot(snapshotInfo.getId(), rscName, storagePoolVO);

VolumeObjectTO volumeTO = (VolumeObjectTO) volumeInfo.getTO();
volumeTO.setPath(volumeInfo.getUuid());
volumeTO.setSize(volumeInfo.getSize());
answer = new CopyCmdAnswer(volumeTO);
} catch (Exception e) {
errMsg = "Failed to create volume from snapshot: " + e.getMessage();
logger.error(errMsg, e);
}
CopyCommandResult result = new CopyCommandResult(null, answer);
result.setResult(errMsg);
return result;
StoragePoolVO storagePoolVO = _storagePoolDao.findById(snapshotInfo.getDataStore().getId());
String rscName = LinstorUtil.RSC_PREFIX + volumeInfo.getUuid();
createResourceFromSnapshot(snapshotInfo.getId(), rscName, storagePoolVO);

VolumeObjectTO volumeTO = (VolumeObjectTO) volumeInfo.getTO();
volumeTO.setPath(volumeInfo.getUuid());
volumeTO.setSize(volumeInfo.getSize());

return new CopyCommandResult(null, new CopyCmdAnswer(volumeTO));
}

@Override
Expand Down
Loading