use cstringio rather than += on string in libev#20
use cstringio rather than += on string in libev#20halfaleague wants to merge 2 commits intoapache:masterfrom
Conversation
|
One thing to keep in mind is that in older versions of PyPy, |
|
Thanks for the pull request and the extra information! I'm going to leave this open for our main Python developer to look it over and see which String builder he wants to use after all. (There will be a delay, but it won't be forgotten. :) ) |
|
The main thing is fixing it, the blob usage is pretty slow otherwise. Thanks again! |
|
Hmm, I'm seeing random hangs when running with these changes. I like the idea of using cstringio, though, so I'll dig in and see what's going on. (By the way, it's generally a good idea to use a separate branch for pull requests instead of master so that unrelated commits don't get mixed in, like happened here. No worries, though.) |
|
Alright, I figured out what was going on, so I went ahead and merged your changes into master along with my fixes: 445d813 Thanks! |
|
Thanks! This driver is very nice! |
I'm glad you like it :) |
added info re: read_repair_chance and tidied up readme a little
PYTHON-589 - inject client request timeout in graph custom payload
The current LibevConnection class is using a string variable _buf, this is used to build up a message from a socket, it is using a += to append to it, this is really slow especially when using blobs.
I have modified it to use a cStringIO and updated the tests, they all seem to run.
Use this or use it as a suggestion for an alternate implementation, thanks!