[AMORO-3383] fix: unified catalog should support iceberg native create_changelog_view procedure#3383
Merged
Merged
Conversation
zhoujinsong
approved these changes
Jan 10, 2025
Contributor
zhoujinsong
left a comment
There was a problem hiding this comment.
LGTM.
Thanks for the contriburion!
zhoujinsong
pushed a commit
to zhoujinsong/amoro
that referenced
this pull request
Jan 21, 2025
…e_changelog_view procedure (apache#3383) * unified catalog support iceberg create_changelog_view procedure * unified catalog support iceberg create_changelog_view procedure
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why are the changes needed?
The unified catalog does not support the Iceberg change metadata table syntax, which makes it impossible to support the create_changelog_view stored procedure.
Brief change log
changessubtablename in class IcebergSparkFormatApart from this, I haven't found any other situations that need to be addressed. As the version upgrades, it will be necessary to align with the list of subTables supported by Iceberg.
How was this patch tested?
Add some test cases that check the changes thoroughly including negative and positive cases if possible
Add screenshots for manual tests if appropriate
Run test locally before making a pull request
Documentation