Improve API server HTTPRoute config based on review feedback#68552
Merged
Conversation
Miretpl
requested changes
Jun 20, 2026
Miretpl
requested changes
Jun 28, 2026
Contributor
Backport failed to create: chart/v1-2x-test. View the failure log Run detailsNote: As of Merging PRs targeted for Airflow 3.X In matter of doubt please ask in #release-management Slack channel.
You can attempt to backport this manually by running: cherry_picker d2d9f4c chart/v1-2x-testThis should apply the commit to the chart/v1-2x-test branch and leave the commit in conflict state marking After you have resolved the conflicts, you can continue the backport process by running: cherry_picker --continueIf you don't have cherry-picker installed, see the installation guide. |
Contributor
|
@somaz94 could you do manual backport to |
1 task
potiuk
pushed a commit
to steveahnahn/airflow
that referenced
this pull request
Jul 8, 2026
* Move API server HTTPRoute under apiServer and add config guards * Require HTTPRoute parentRefs and document API server Ingress mutual exclusivity * Fail fast on empty HTTPRoute parentRefs via schema minItems * Apply pretty-format-json formatting to values.schema.json (cherry picked from commit d2d9f4c)
Miretpl
pushed a commit
that referenced
this pull request
Jul 9, 2026
* Move API server HTTPRoute under apiServer and add config guards * Require HTTPRoute parentRefs and document API server Ingress mutual exclusivity * Fail fast on empty HTTPRoute parentRefs via schema minItems * Apply pretty-format-json formatting to values.schema.json (cherry picked from commit d2d9f4c) Co-authored-by: somaz <112675579+somaz94@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #67675 addressing post-merge review feedback from @Miretpl. The
original PR has not been released yet, so these refinements land before the
upcoming chart release as requested.
Changes:
httpRoute.apiServer.*toapiServer.httpRoute.*— it is an API-server setting, not a global one(values.yaml, values.schema.json, template, docs, tests).
apiServer.httpRoute.enabledis true but the Gateway API HTTPRoute CRD is not installed (via
.Capabilities.APIVersions.Has).ingress.apiServer.enabledandapiServer.httpRoute.enabledare set — HTTPRoute is an alternative to the API server Ingress.
spec.parentRefs/spec.rulesstructures, addasserts to the validation test, inline a single-use variable, and split the
parametrized creation test into separate cases (no inner
if).api_versionsparameter to therender_charthelper soCapabilities-gated templates render offline.
Validation:
helm templaterenders for enabled/disabled and fails as expected for both guardsrelated: #67675
Was generative AI tooling used to co-author this PR?
Generated-by: Claude Code (Opus 4.8) following the guidelines