Use project-pinned uv and check min version in prek hooks#65531
Open
potiuk wants to merge 5 commits intoapache:mainfrom
Open
Use project-pinned uv and check min version in prek hooks#65531potiuk wants to merge 5 commits intoapache:mainfrom
potiuk wants to merge 5 commits intoapache:mainfrom
Conversation
Prek hooks that invoke uv (directly or via breeze) now prefer `.venv/bin/uv` from the project's main virtualenv over PATH uv so the uv version is pinned by the project, and verify it satisfies the minimum declared in `[tool.uv] required-version` in the root pyproject.toml. If the main-venv uv is missing, the mypy local runner falls back to PATH uv with a warning. An outdated uv fails fast with upgrade instructions instead of emitting confusing downstream errors.
`breeze`'s `perform_environment_checks` already validates Docker and docker-compose versions before running any command; extend it with a matching `check_uv_version` that reads `[tool.uv] required-version` from the root `pyproject.toml` and confirms the `uv` on PATH satisfies it, matching the pattern the prek hooks now use. Users get the same clear "upgrade uv to X.Y.Z" error from `breeze` commands that they'd see from a standalone prek hook, instead of a confusing failure deeper in the shell bootstrap.
`[tool.uv] required-version` is the minimum uv contributors must have installed, not the exact uv version CI pins to. Bumping it on every uv release would force every contributor to upgrade uv in lockstep, which is far more churn than the floor check is worth. Leave an explicit comment both at the declaration site and in `scripts/ci/prek/upgrade_important_versions.py` (where `UV_PATTERNS` could be tempted to pick it up) so a future contributor doesn't wire it into the automated bump by accident. The breeze/prek uv version checks already read it dynamically and tolerate a stale floor.
The uv version check is not docker-specific — it applies to any breeze entry point that invokes uv, including flows that never talk to Docker. Move `check_uv_version` and `_read_required_uv_version` from `docker_command_utils` into the generic `environment_check` module, use `packaging.version.parse` directly instead of docker-scoped `compare_version`, and move the unit tests alongside. `perform_environment_checks` continues to call it after the Docker checks so the behavior is unchanged.
`[tool.uv] required-version` is bumped manually (by design — see the comment next to it in pyproject.toml). When it moves, any hard-coded uv version in tests that represents that floor needs to move too or the fixtures silently drift. Add a `sync-uv-min-version-markers` prek hook that reads the current `required-version` and rewrites any line tagged with a `# sync-uv-min-version` marker to match. The hook fails (prek convention) when it makes a change, so the contributor just re-stages. The existing `check_uv_version` tests carry the marker on their mocked floor constant so a future bump to `required-version` will propagate through the marker and keep the success-path assertions in sync.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prek hooks that invoke
uv(directly from the mypy local runner or indirectly viabreeze) now:uvfrom the project's main.venv/bin/uvover whateveruvis onPATH, so the uv version used to sync and run mypy is pinned by the project.uvis already part of thedevgroup viaapache-airflow[all], so a regularuv syncinstalls it. The mypy local runner falls back touvonPATHwith a warning if.venv/bin/uvis missing.uvthey are about to invoke meets the minimum declared in[tool.uv] required-versionin the rootpyproject.toml, and fail fast with upgrade instructions (uv self update/uv sync) if it is older — instead of letting a stale uv produce confusing downstream errors.Implemented as a manual check (regex parse of
pyproject.toml, tuple compare ofuv --version) inscripts/ci/prek/common_prek_utils.py; wired intoinitialize_breeze_prek()so every breeze-calling hook gets it, and called explicitly from the mypy local runner against the selecteduv_bin.AGENTS.mdandcontributing-docs/08_static_code_checks.rstupdated to describe both behaviors.Was generative AI tooling used to co-author this PR?
Generated-by: Claude Code (claude-opus-4-7) following the guidelines