This repository was archived by the owner on Mar 20, 2024. It is now read-only.
[WIP] build: update build process to only bundle .js and .d.ts files - #50
Closed
CaerusKaru wants to merge 1 commit into
Closed
[WIP] build: update build process to only bundle .js and .d.ts files#50CaerusKaru wants to merge 1 commit into
CaerusKaru wants to merge 1 commit into
Conversation
CaerusKaru
force-pushed
the
build
branch
3 times, most recently
from
November 1, 2017 00:26
4c4e199 to
bd0f2a9
Compare
This PR is meant to stop packaging full TypeScript files in the library. This breaks testing capabilities in Angular, and is overall unnecessary. Instead, we transpile all files using tsc into a separate directory, and only publish that directory, with the root files (index.js and index.d.ts) specified in package.json. There are no breaking changes in this PR, but if you are building from source, please make sure to update your dev dependencies. * add outDir to tsconfig for bundling * upgrade to angular v5 and use new compiler instead of just tsc * clean up package.jsom npm scripts * add exports to index.ts to allow for root import * move inline builder to separate directory * add dev dependencies for TypeScript building * add files and directories to npmignore to allow for root packaging * move protractor config to root level * change webpack to use ts-loader * Fixes angular#49 BREAKING CHANGE: Due to the change in how folders are exported, all imports from `preboot` must come as a root import, e.g. `import {ServerPrebootModule} from 'preboot';` instead of `import {ServerPrebootModule} from 'preboot/server';`
Member
Author
|
@jeffwhelpley Here's the state of this PR so far: it builds and everything works great, but e2e is failing because this PR bumps the deps to Angular v5, which: a) no longer uses The upgrade to v5 was necessary to fix some AOT issues with the new build format (which necessitated switching to We'll need another testing solution for JIT, or we could alternatively compile it with AOT and test it that way. |
Member
Author
|
Closing in favor of #51 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is meant to stop packaging full TypeScript files in the
library. This breaks testing capabilities in Angular, and is
overall unnecessary. Instead, we transpile all files using tsc
into a separate directory, and only publish that directory, with
the root files (index.js and index.d.ts) specified in package.json.
add outDir to tsconfig for bundling
clean up package.jsom npm scripts
add exports to index.ts to allow for root import
move inline builder to separate directory
add dev dependencies for TypeScript building
add files and directories to npmignore to allow for root packaging
move protractor config to root level
change webpack to use ts-loader
Fixes refactor: change project structure to Angular Library format #49
BREAKING CHANGE:
Due to the change in how folders are exported, all imports from
prebootmust come as a root import, e.g.import {ServerPrebootModule} from 'preboot';instead ofimport {ServerPrebootModule} from 'preboot/server';