Skip to content

fix(database): allow null values for equalTo, etc. - #809

Merged
davideast merged 2 commits into
angular:masterfrom
cartant:issue-704-part-2
Feb 15, 2017
Merged

fix(database): allow null values for equalTo, etc.#809
davideast merged 2 commits into
angular:masterfrom
cartant:issue-704-part-2

Conversation

@cartant

@cartant cartant commented Feb 5, 2017

Copy link
Copy Markdown
Contributor

Checklist

Description

The previous PR for #704 did not include tests and did not completely fix the issue, as null values were swallowed with the query observable. This PR addresses that and includes tests.

Also, this PR ensures that the query observable emits undefined if values are not specified for equalTo, startAt or endAt - as null has a specific meaning.

@davideast
davideast merged commit 561e7b7 into angular:master Feb 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants