fix(database): allow null values for equalTo, etc. - #809
Merged
Conversation
cartant
force-pushed
the
issue-704-part-2
branch
from
February 8, 2017 04:33
16a8ba1 to
df3028b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
npm install,npm run build, andnpm testrun successfully? yesDescription
The previous PR for #704 did not include tests and did not completely fix the issue, as
nullvalues were swallowed with the query observable. This PR addresses that and includes tests.Also, this PR ensures that the query observable emits
undefinedif values are not specified forequalTo,startAtorendAt- asnullhas a specific meaning.