Skip to content

chore(): release @angular/fire 5.0 🎉🔥🕺 - #1854

Merged
jamesdaniels merged 10 commits into
masterfrom
package_changes
Sep 6, 2018
Merged

chore(): release @angular/fire 5.0 🎉🔥🕺#1854
jamesdaniels merged 10 commits into
masterfrom
package_changes

Conversation

@jamesdaniels

@jamesdaniels jamesdaniels commented Sep 4, 2018

Copy link
Copy Markdown
Contributor

It's happening!

@davideast
davideast self-requested a review September 4, 2018 18:23

@davideast davideast left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jamesdaniels

jamesdaniels commented Sep 4, 2018

Copy link
Copy Markdown
Contributor Author

FYI angular-fire-5.0.0.tgz; going to toss this into my test projects and give it a whirl.

@jamesdaniels jamesdaniels changed the title Using @angular/fire Release @angular/fire 5.0! Sep 4, 2018
@jamesdaniels jamesdaniels changed the title Release @angular/fire 5.0! Release @angular/fire 5.0 🎉🔥🕺 Sep 4, 2018
@jamesdaniels jamesdaniels changed the title Release @angular/fire 5.0 🎉🔥🕺 chore(): release @angular/fire 5.0 🎉🔥🕺 Sep 4, 2018
@itsthesteve

Copy link
Copy Markdown

So happy to see it come under the @angular scope!!

@EdricChan03

Copy link
Copy Markdown
Contributor

So will the angularfire2 package be marked as deprecated?

This can be a breaking change for old projects that still rely on this (soon to be) old package.

@davideast

Copy link
Copy Markdown
Collaborator

@Chan4077 We will do a final release of 5.0.0 for the angularfire2 package. However, we will mark it as deprecated and move folks over to @angular/fire. Do you have any other ideas to help ease the move?

@EdricChan03

EdricChan03 commented Sep 5, 2018

Copy link
Copy Markdown
Contributor

Schematics maybe?

EDIT: Maybe an upgrade schematic in the 5.0.0 release that makes consumers use @angular/fire instead?

@davideast

Copy link
Copy Markdown
Collaborator

@Chan4077 That's a fantastic idea

Comment thread tools/build.js
@jamesdaniels
jamesdaniels merged commit 91ec37e into master Sep 6, 2018
@jamesdaniels
jamesdaniels deleted the package_changes branch September 6, 2018 22:58
@EdricChan03

EdricChan03 commented Sep 7, 2018

Copy link
Copy Markdown
Contributor

@davideast Will the angularfire2 package be marked as deprecated?

And will this repository be renamed to 🔥?

P.S. I don't literally mean rename this repository to a fire emoji. 😆

@davideast

Copy link
Copy Markdown
Collaborator

@Chan4077 Yes it will be! And why not an emoji 😂? Just kidding! We will likely do a rename soon for the repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants